[2.1] Clicking "Pin" twice on an entity does not unpin, but creates a second pin

[worph]

What did you do?

I pinned a space platform to my sidebar.
When I wanted to remove it again, and clicked the same button again.

What happened?

It created a second identical pin after it.

What I expected

I expected it to unpin the previous pin.
(On closer expection I also expected the "pin" icon to turn into an "unpin" icon.)

Does it happen always, once, or sometimes?

Happens all the time.



This is not super important, it might be intended, you can easily work around it by using the very obvious trash icon next to the pins.
But it still seems wrong.
I cannot think of a reason why it should function like this, nor why anybody would ever need a second pin for the same entity.

[Rseding91]

This is a feature request and as such does not go in bug reports.

[worph]

I accept that.
Let me just say:
If a GUI let's me set a flag, but there is no option to unset that flag within the same GUI window, I consider that to be a bug. (when it might as well use the same button to unset that flag)
But again, fair enough.

[worph]

Thanks to this reply, I finally understand why this isn't considered.
Only when pinning cars on several planets and trying to rename them I noticed that you can give each pin a custom label. (or more precisely, why I would want to do that)
This is perfect for having a pin on each car(or tank, or spidertron) on each surface. (They should still have a pin button of their own)

But what made me post this suggestions in the first place was a misunderstanding of how pins work, because why would I give a pin on a platform a label, when I can already rename the platform? Also why would I need two pins on the same platform hub?
But the internal refrence logic is one way. Pins -> reference other objects or locations, but not the other way around.

I still think that pinning a platform, specifically, should include an additional check if that platform (or car, or tank, or spidertron, or train, or any entity) has been pinned already and not only remove the pin but also turn the pin icon into an unpin icon while it is pinned.

The basic assertion and intuition holds true:
- There is no need to pin any platform hub (or any entity) twice, ever.