[1.1.110] Mod updater fails to check for updates when certain mods are requested

[RorySys]

I was attempting to update mods on my k2se+rampant instance in order to potentially migrate to Factorio 2.x.
Space Exploration requires loading the save in the latest release first, before updating the game to 2.x.
In the process, I was updating mods to their latest 1.1 releases via the in-game mod manager.

I observed a red box in the "Updates" tab that said "Unable to check for updates".

FailedToUpdate.png (16.84 KiB) Viewed 138 times

Upon seeing this, I checked the console output of the game and observed this message:
```
52.780 Info HttpSharedState.cpp:58: Downloading https://mods.factorio.com/api/mods?page ... ue&lang=en
53.970 Error ModInfo.cpp:138: Mod Krastorio2 dependency + ChangeInserterDropLane >= 1.1.0 not matching pattern "[?|(?)|!|~] ModName [ModVersion specifier]".
53.973 Error ModPortal.cpp:211: Failed to fetch mod information: Failed to parse the mod portal API response: Mod Krastorio2 dependency + ChangeInserterDropLane >= 1.1.0 not matching pattern "[?|(?)|!|~] ModName [ModVersion specifier]".
```

Log files attached, however I did not check whether both are relevant.

The workaround I have found in the meantime is to download specifically these 2 mods from the mod portal: `Krastorio2` and `space-exploration`.
These 2 specific mods are the only ones I've found to be problematic. This seems to be perfectly consistent.

My theory (unverified): I believe the mod list API may be returning mods for 2.0 (which may have added a new version comparison operator), and it's presence causes 1.0 to fail to parse these mods for update checking. However, I would have expected the API to respect the `version` parameter where given.

[robot256]

This looks like it is directly caused by the addition of the '+' dependency prefix for recommended mods that was added in 2.1. (The 2.0 executable also can parse this correctly).

It looks like for some reason the mod portal is including the info.json for the latest 2.1 releases in the bundle sent when the 1.1 executable requests it, and the 1.1 parser is failing.

Sideloading the manually-downloaded versions of those mods is the best workaround. I don't know if the fix for this lies on the mod portal side or the game side.

[vinzenz]

Deployed a hotfix on the mod portal. '+' dependencies are now served as '?' to older clients. Might change it later to filter incompatible mod releases entirely.