[2.1.11] Crash when selecting modded-in entity in Factoriopedia (Factoriopedia::generateAmmoCategoryLine 1078)

[rullaf]

What happens: A specific new entity added by a mod being selected in Factoriopedia crashes the game every time.

I'm running into this on build 86962 mac-arm64

Setup:
* Factorio 2.1.11 + Space Age 2.1.11 (with Elevated Rails + Recycler)
* mod Suspension Coffin 1.1.0 (https://mods.factorio.com/mod/suspension-coffin)

Repro:
* Start a new singleplayer Freeplay game with default settings
* Open Factoriopedia by clicking the GUI button or option-clicking anything in the game
* Open the Space tab in Factoriopedia
* Attempt to select the “Suspension Coffin” entity, at which point the game crashes

[rullaf]

Simpler repro

Setup:
* plain Factorio 2.1.11
* land-mine-factoriopedia-crash-repro_0.1.0.zip (attached)

Code: Select all

local entity = table.deepcopy(data.raw["land-mine"]["land-mine"])

entity.name = "land-mine-without-ammo-category"
entity.localised_name = {"", "Land mine without ammo category"}
entity.ammo_category = nil

data:extend({entity})

Repro:
* attempt to open land-mine-without-ammo-category entity in Factoriopedia to experience the crash

[boskid]

Thanks for the report. Issue is now fixed for 2.1.12.