[2.1.9] Crash on LuaHelpers::write_file

[RedRafe]

Hello,

game crashes when in control I use LuaHelpers::write_file with optional parameter "for_player=0"

Code: Select all

-- crashes in single player
helpers.write_file('file.json', data, false, 0)

-- does NOT crash in single player
helpers.write_file('file.json', data, false)

Attached is the log of the crash.

[boskid]

I see, write_file's for_player was never implemented to work when control.lua top level is executed because at that stage it is not yet decided who is a local player or if thats a server. Before `helpers` existed, write_file was on `game` which was not available at that stage and it was not possible to do writes yet.

[boskid]

Thanks for the report. Issue is now fixed for 2.1.10. When trying to use write_file with for_player != 0 from top level, write will be skipped because at that point local player cannot be decided yet. When using for_player == 0, it will not crash.

[RedRafe]

Thanks, seems reasonable.
Can I also ask for this to be added to the new API docs when released (if not already taken care of).
Ty

[Bilka]

Docs updated for 2.1.10.