[2.1.9] Space Science pack recipe icon defined

Bugs that are actually features.
User avatar
Alkumist
Burner Inserter
Burner Inserter
Posts: 19
Joined: Mon Feb 12, 2018 11:38 pm
Contact:

[2.1.9] Space Science pack recipe icon defined

Post by Alkumist »

ive had a Color blind science pack mod for a while now, and it changes every science pack icon except for Space Science pack when viewing in assembler on the unlock recipe in the technology view.

i expected my mod to properly change icons uniformly with the same mod structure of
data.raw.item["space-science-pack"].icon = "__cb-science-Alk__/graphics/icons/space.png"
data.raw.technology["space-science-pack"].icon = "__cb-science-Alk__/graphics/technology/space.png"

like it correctly does for every other science pack, including the ones added in Space Age.

i did some digging and in space-age > prototypes > recipe.lua line 751 Space-science-pack gets a icon defined while NO OTHER RECIPIE does.
commenting out that single line produces the expected result, allowing my mod to properly change the icon uniformly.
Rseding91
Factorio Staff
Factorio Staff
Posts: 17070
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: [2.1.9] Space Science pack recipe icon defined

Post by Rseding91 »

Thanks for the report however this is not a bug.
If you want to get ahold of me I'm almost always on Discord.
User avatar
Alkumist
Burner Inserter
Burner Inserter
Posts: 19
Joined: Mon Feb 12, 2018 11:38 pm
Contact:

Re: [2.1.9] Space Science pack recipe icon defined

Post by Alkumist »

thats disappointing, but i fail to see how its not a bug.
unless the bug is actually that the other science packs not defining a recipe icon is the bug...
Rseding91
Factorio Staff
Factorio Staff
Posts: 17070
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: [2.1.9] Space Science pack recipe icon defined

Post by Rseding91 »

Recipes can define any icon they like - that is an intended working part of the prototypes system. When writing a mod you can modify any part of any definition you like - that is also part of the modding system.
If you want to get ahold of me I'm almost always on Discord.
berggen
Long Handed Inserter
Long Handed Inserter
Posts: 52
Joined: Tue Sep 01, 2020 7:12 pm
Contact:

Re: [2.1.9] Space Science pack recipe icon defined

Post by berggen »

FWIW, it looks like the author of the mod in question fixed the mod 9 hours ago to correctly override the recipe icon as well: https://github.com/Alkumist/cb-science- ... -fixes.lua

Edit: Oh, that's you :lol:
User avatar
Alkumist
Burner Inserter
Burner Inserter
Posts: 19
Joined: Mon Feb 12, 2018 11:38 pm
Contact:

Re: [2.1.9] Space Science pack recipe icon defined

Post by Alkumist »

Edit: Oh, that's you :lol:
yup. I was previously using Quality Glassworks backend, and i have notified them through the mod portal that recipe icons also need to be changed.
Post Reply

Return to “Not a bug”