[2.1.9] Headless --until-tick option requires non-existent --load-game option

[berggen]

What did you do?
1. Ran headless with --until-tick:

Command:

Code: Select all

./headless_2_1_9/bin/x64/factorio --mod-directory mods_2_0_77/ --until-tick 100

Output:

Code: Select all

0.000 Error UntilTick.cpp:17: --until-tick requires --load-game

2. Ran headless with --load-game:

Command:

Code: Select all

./headless_2_1_9/bin/x64/factorio --mod-directory mods_2_0_77/ --until-tick 100 --load-game map_2_0_77

Output:

Code: Select all

Option ‘load-game’ does not exist

...rest of output omitted...

3. Ran headless help and grepped for load:

Command:

Code: Select all

./headless_2_1_9/bin/x64/factorio --help | grep load

Output:

Code: Select all

                                --create, --start-server-load-scenario or
                                --start-server-load-scenario or
                                --start-server-load-scenario. See
                                --start-server-load-scenario or
                                --generate-map-preview. If provided, this is loaded first and
      --start-server-load-scenario [MOD/]NAME
                                start a multiplayer server and load the
      --start-server-load-latest
                                start a multiplayer server and load the
      --benchmark FILE          load save and run benchmark
                                map will reload after each run. Default is 1
      --log-shared-tile-layers  After loading prototypes logs which tile

What did you expect to happen?
I expected the error message on attempting to use until-tick to provide correct guidance. If until-tick is not supported on headless, don't print it in the usage on headless. If it is supported on headless, provide an updated error message.

[Techjar]

Did you try passing --start-server (or --create) with the name of a save file? The --load-game might just be an outdated error message that was overlooked.

[Loewchen]

--load-game does not work on headless and I don't think --until-tick does either.

[berggen]

Did you try passing --start-server (or --create) with the name of a save file? The --load-game might just be an outdated error message that was overlooked.

Most recent command which works:

Code: Select all

./headless_2_1_9/bin/x64/factorio --mod-directory mods_2_1_9/  --start-server map_2_0_77  --server-settings headless_2_1_9/data/server-settings.example.json

Adding until-tick to the above runs without crashing, but the until-tick behavior is ignored. Headless should probably not show until-tick and not accept it as a start up option in that case:

Code: Select all

./headless_2_1_9/bin/x64/factorio --mod-directory mods_2_1_9/  --start-server map_2_0_77  --server-settings headless_2_1_9/data/server-settings.example.json --until-tick 100

[berggen]

--load-game does not work on headless and I don't think --until-tick does either.

--load-game is not even a valid option for headless. --until-tick is a valid option, but does nothing.

[Rseding91]

It looks like the options are pretty much random these days - people haven't paid attention to what section new ones are added in and so some that don't work in headless are available there.

[Rseding91]

I've fixed a few options not intended to be in the headless build for the next release.