[2.0.76] output is same quality as ingredients if quality chance drops during crafting, even if chance > 100%

User avatar
planetfall
Inserter
Inserter
Posts: 22
Joined: Fri May 04, 2018 7:49 pm
Contact:

[2.0.76] output is same quality as ingredients if quality chance drops during crafting, even if chance > 100%

Post by planetfall »

Steps to reproduce: set intrinsic quality bonus of a machine very high so that module changes cannot bring the chance below 100%. Start producing items from normal ingredients, note they're all above normal quality. Add a speed module mid-craft and note a single normal output appears. Also happens if there are quality modules in the machine and you remove one or you place a speed beacon.

Expected behavior: either quality is rolled when crafting begins and that result is locked in, or quality is rolled based on the machine's state at the moment the result is produced.

Admittedly a minor corner case based around giving things levels of stats they were not designed to have. This could e.g. cause belt contamination when switching out modules when using a mod that greatly boosts quality chances but limits maximum_quality_jump to 1 and having built a system without quality filters because they aren't needed during normal operation (which was what the mod I was testing when I discovered this does, and why it was so annoying)
Attachments
factorio-current.log
(7.39 KiB) Downloaded 11 times
testmod_0.1.0.zip
(707 Bytes) Downloaded 12 times
fulgora? i find it quite empty actually
Nidan
Filter Inserter
Filter Inserter
Posts: 369
Joined: Sat Nov 21, 2015 1:40 am
Contact:

Re: [2.0.76] output is same quality as ingredients if quality chance drops during crafting, even if chance > 100%

Post by Nidan »

planetfall wrote: Mon May 04, 2026 8:55 am Expected behavior: either quality is rolled when crafting begins and that result is locked in, or quality is rolled based on the machine's state at the moment the result is produced.
Both of these are exploitable by controlling speed beacons with power switches. Currently quality is rolled at the start and any loss in quality chance invalidates the quality roll (see this post).
(Ideally the quality roll would be evaluated according to the lowest chance observed during the craft, but that means storing that chance and the initial roll, which will require more memory, which is something that's frequently rejected by the devs.)

tl;dr: not a bug
User avatar
boskid
Factorio Staff
Factorio Staff
Posts: 4535
Joined: Thu Dec 14, 2017 6:56 pm
Contact:

Re: [2.0.76] output is same quality as ingredients if quality chance drops during crafting, even if chance > 100%

Post by boskid »

This bug report lives in a grey area of "working as intended" for 2.0, and "fixed for 2.1" because this logic was already changed for 2.1 due to unrelated features.

Given there will be a behavior change that seems to align with your expected outcome, i will classify this as Fixed for 2.1 -> product will be based on lowest quality effect that was seen by the machine during the entire crafting process as to avoid abuses.
Post Reply

Return to “Fixed for 2.1”