[2.0.76] List of pins doesn't respect game_view_settings

[aglaron]

When placing a new pin, visibility of the list of pins (under minimap) behaves inconsistently with current state of player.game_view_settings. It doesn't appear if right side views are currently hidden, it doesn't hide when right side views are told to hide.

Steps:

1. Start new Freeplay game.
2. Enter in console:

Code: Select all

/c game.players[1].game_view_settings.show_research_info = false
/c game.players[1].game_view_settings.show_side_menu = false
/c game.players[1].game_view_settings.show_minimap = false

(Expected: there are no visible UI elements on the right side of the screen)

3. Place a pin (Alt + Right Click by default)

Actual: List of pins doesn't appear.
Expected: see below.

4. Enter in console (show minimap):

Code: Select all

/c game.players[1].game_view_settings.show_minimap = true

Actual: List of pins appear along with minimap.
Expected: see below.

5. Enter in console (hide minimap):

Code: Select all

/c game.players[1].game_view_settings.show_minimap = false

Actual: Every UI element on the right side of screen is hidden, except list of pins.

Expected (either one of three):
1. (most preferred) List of pins appears after step #3. A separate setting in game_view_settings allows control over visibility of list of pins.
2. List of pins hides after step #5. Only affected by show_minimap (see Notes).
3. (least preferred) List of pins hides after step #5. Visibility affected by presence of any right side UI element (see Notes).

Notes:
- Any one of 3 right side UI elements can be used instead of minimap in steps #4 and #5.

[Rseding91]

There's 1 bug here and 1 feature request.

The bug: adding a pin to the pins GUI doesn't trigger the right-pane GUI to turn visible.
The feature request: a game_view_setting for the pins GUI visibility (to match the other widgets in the right-pane GUI).

[aglaron]

Would you like me to extract the feature request?

[Rseding91]

This is now fixed for 2.1 and I added show_pins_gui as well.