[2.0.72] pollution has no quality diamond when energy usage scales with quality

[Quezler]

steps to reproduce:
- install krastorio 2
- unzip and open `prototypes/compatibility/quality-updates.lua`
- edit that file like https://codeberg.org/raiguard/Krastorio ... /702/files does, the below code snippet is a simplification:

Code: Select all

data.raw.furnace["kr-air-purifier"].energy_usage_quality_multiplier = {normal = 1, legendary = 2.5}
data.raw.furnace["kr-air-purifier"].quality_affects_energy_usage = true

expected behavior: since pollution changes based on the energy usage it should have a blue icon that shows the emissions for each quality level.

[Bilka]

Noting that boilers in the base game also have this problem.

[Rseding91]

Thanks for the report however this is currently working correctly. Pollution is not directly effected by quality. That is: the emissions are not multiplied by any part of quality on the entity. When the game decides "how much pollution" it directly reads what's on the prototype. This is in contrast to something like the container entities inventory size where the size is calculated as prototype-size * quality-modifier.

The reason you see pollution "change" on the entity is because the amount of pollution that this entity emits is determined by how much energy it consumes and energy *is* directly changed by the entities quality level.

However - it's not as simple as that. An entity can have static emissions-per-tick by just existing - and have emissions-per-energy-consumed. To complicate it more - some entities don't support emissions-per-entity-consumed and only have static emissions.

As the quality diamonds are implemented now they only show if something is directly modified by the entities quality level (prototype-value ... quality-modifier).