Train stop name max length changed in 2.0

Bugs that we were not able to reproduce, and/or are waiting for more detailed info.
Mazzelfassel
Burner Inserter
Burner Inserter
Posts: 7
Joined: Fri Dec 04, 2015 11:39 pm
Contact:

Train stop name max length changed in 2.0

Post by Mazzelfassel »

I recently opened an old save where I noticed that some trainstop names broke after updating to 2.0. The stations in question have a lot of icons in their name (basically what they provide/request) which causes the name to become very long reaching a limit of 200 characters. They are cut off at the end with the text of the last icon being written partially. Before the update all names were displayed without any problems.

I checked the patch notes but did not spot anything mentioning this directly.
Rseding91
Factorio Staff
Factorio Staff
Posts: 16469
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: Train stop name max length changed in 2.0

Post by Rseding91 »

Can you please post a save file showing the issue.
If you want to get ahold of me I'm almost always on Discord.
Mazzelfassel
Burner Inserter
Burner Inserter
Posts: 7
Joined: Fri Dec 04, 2015 11:39 pm
Contact:

Re: Train stop name max length changed in 2.0

Post by Mazzelfassel »

Here is a save depicting the issue. I've added a trainstation that reached the character limit after using more than 9 item icons. I dont know what the limit was before the update but I had stations with at least 10 icons or more.
Attachments
station_naming.zip
(4.25 MiB) Downloaded 89 times
sadris
Inserter
Inserter
Posts: 32
Joined: Thu Oct 02, 2014 5:55 pm
Contact:

Re: Train stop name max length changed in 2.0

Post by sadris »

I use Train Schedule Signals mod to setup my train routes. I sometimes have complicated stops that are both requesters and providers. The limited length of train stop names is causing my complicated route setup to not function. There is a suggestion about this issue here -- but this might be a bug instead of a suggestion?

Either way, the max length should be increased by a lot.
eugenekay
Filter Inserter
Filter Inserter
Posts: 958
Joined: Tue May 15, 2018 2:14 am
Contact:

Re: Train stop name max length changed in 2.0

Post by eugenekay »

[item=transport-belt][item=transport-belt][item=transport-belt][item=transport-belt][item=transport-belt][item=transport-belt][item=transport-belt][item=transport-belt][item=transport-belt][item=tran is 199 characters long (from station_naming.zip attached above). This is the longest that can be entered by Ctrl-V.... but you can type 1 additional character for a total of 200. This suggests that there is an off-by-one issue in the Input-text-box function.

In 1.1.110 there is an explicit error message above 1024 characters:
01-20-2026, 21-55-43.png
01-20-2026, 21-55-43.png (35.72 KiB) Viewed 46 times
Importing the attached save to 2.0.73 yields [item=transport-belt][item=transport-belt][item=transport-belt][item=transport-belt][item=transport-belt][item=transport-belt][item=transport-belt][item=transport-belt][item=transport-belt][item=trans (exactly 200 characters).
Attachments
Long-Train-Stop-Names.zip
(1.41 MiB) Downloaded 1 time
Post Reply

Return to “Pending”