[2.0.71] *Blueprint* Turret Read Ammo missing

[wspikes]

This is certainly related to 131362. Still, I'm filing this as a separate bug because...

Top-line questions:
I'm aware that the underlying bug is fixed for already built entities, however

1. Will the fix in 131362 also fix/restore the control behavior for BPs in the player and/or game BP libraries?
2. Did an upgrade migration irrevocably strip this from our blueprint storages, such that players will need to fix their BPs later manually?

If we're going to have to fix things manually on our side later, it's understandable -- things happen, and it's no big deal -- but I wanted to make sure that this impacted area was also known.

Setup for reproduction, in Factorio 2.0.66:

1. Create a blueprint that has the following:

• Left turret has read-ammo enabled
• Green wire connecting the two turrets
• Right turret has enable if ammo from the left turret is gone
• Both turrets request 5 ammo

2. Store the blueprint in the player's BP library.

For reference, here's the string for the BP, as generated in version 66:

Code: Select all

0eNrFUtFqwzAM/Bc9O7CGJl0C+5ISgpNomVgiB9nu1hX/++wE2kFH2duwwUj4TneSLtBNHhchdlBfgHrDFurjBSyNrKeUYz0j1DB6zpwXQQdBAfGAn1DvQqMA2ZEj3HBrcG7Zzx1K/KB+wStYjI0Qw4k/0mSlgnN89pE5KnBiprbDN30iI+mLoB5aPc8GaiceU32H81aQhh8iF0LpicdMjOfBZrMe9Rcxwg0SEdwSn6JQI+eN4hZFvdbp/h3qpyTFp7YUoQnxqjtz+Z/M5Y+99SS9J9ci627CYXOorukIGa5sryTWtXejeeQ6DdTpZGM1NC9atEuV4QXC/zQyrswHybovx53K02majTZWvu2jghOKXa0XZV7tq6o4HPZl+VyF8A16Ku+j

Reproduction, in 2.0.71:

1. Upgrade to 2.0.71, then go into a new game.
2. Place the BP from the library
3. Observe that the left turret no longer has read-ammo enabled, and the right turret is now prematurely enabled.
4. Critically/concerningly, export the BP from the library as a string, and note that it's changed.

For reference, here's the string for the BP, as updated by version 71:

Code: Select all

0eNrFUtFqwzAM/Bc9O9BmbdcG9iUlBCfRMrFEDrLdrSv598kJNIONsbdhg5HQne5k3aDuI45CHKC4ATWOPRTnG3jq2PYpx3ZAKKCLnIUoggEmA8QtvkOxnUoDyIEC4YKbg2vFcahRtMD8gDcwOq8Qx4lfabKDgas+u8QccFioqP3SfiSUhrjLxEVufTbYzn4QI6wQRXBFfFEJTq4LxRqpEh9s8wrFxkCjJGp4P5WTXvNNdv4n2fmqWucWxPVVjS/2Qk5SRUPSRAoVsq17VDNBIpp7WiHtne2ZxIfq29B/c52+KthkYzY0jFZsSJ3hCab/GaQuwxvJvAnnrcnTKcuFVjuvm2bgguJn6/tDftqdTvvj5nH3cDhO0yemJuFj

Dumping this as JSON, then piping it into a diff, shows that the turret's control_behavior in the BP is completely gone -- not just as applied to the built entities.

[wspikes]

With 72 released and containing the fix for 131362, this can probably be closed.

> 1. Will the fix in 131362 also fix/restore the control behavior for BPs in the player and/or game BP libraries?

No, it appears that having loaded game version 71 permanently cleared out the read-ammo setting in our player (and likely also game) BP library. Upgrading to 72 did not restore the control behavior, and BPs will need to be manually fixed.

Yes, save-load of BP libraries does otherwise seem to work again.