QualityPrototype extended

[thesixthroc]

I appreciate that most of these entries are not capped at 1, because that would break the already working property for the Inverted Quality mod.

How is that? So far a QualityPrototype::level is uint32, which means a default_multiplier = `1 + 0.3 * level` was never able to go below value of 1: even if i would keep the limits for multipliers to be >= 1, it would still not be able to break anything because all the values are carefully set to keep backward compatibility. By allowing values to go down to 0.01 i am effectiely extending what is possible.

To correct myself, the problem only comes when the modifier affects something which cannot also be controlled by the entity's prototype fields. This is not the case for the extensions you list, they indeed just extend functionality.

For more details: Inverted Quality has Normal at level 5 but also wants Normal to work the same as it does in vanilla. Properties like `mining_drill_resource_drain_multiplier` cause a problem, because since it is capped at 1, it is not possible for levels to be worse than Normal while keeping Normal unchanged from vanilla (as one cannot compensate for its effect by nerfing all mining drill prototypes by 5 quality levels).

[boskid]

QualityPrototype.crafting_machine_extra_module_slots

Also possibly CraftingMachinePrototype.quality_affects_module_slots (this has some precedent; see CargoWagonPrototype.quality_affects_inventory_size and LabPrototype.uses_quality_drain_modifier)

Added QualityPrototype::beacon_module_slots_bonus.
Added BeaconPrototype::quality_affects_module_slots.
Added QualityPrototype::crafting_machine_module_slots_bonus.
Added CraftingMachinePrototype::quality_affects_module_slots.
Added QualityPrototype::mining_drill_module_slots_bonus.
Added MiningDrillPrototype::quality_affects_module_slots.
Added QualityPrototype::lab_module_slots_bonus.
Added LabPrototype::quality_affects_module_slots.

[Veden]

Would adding entity resistance multiplier one for flat values and one for percentages be possible and reasonable?

[boskid]

For Mining Drills (in particular, thematically non "mining" collectors, like the flower harvesting drone things from pY), a multiplier for mining_search_radius.

Given that mining radius affects area with square, i decided that multiplier would be a little too much and an additive bonus would be more suitable.

Added QualityPrototype::mining_drill_mining_radius_bonus.
Added MiningDrillPrototype::quality_affects_mining_radius.

[MrSmoothieHuman]

Actually, since mining drills just got their radius increased with an additive bonus, could beacons get one too?

[boskid]

Actually, since mining drills just got their radius increased with an additive bonus, could beacons get one too?

Added QualityPrototype::beacon_supply_area_distance_bonus.
Added BeaconPrototype::quality_affects_supply_area_distance.

[LuziferSenpai]

Would this also be here correct?

viewtopic.php?t=115984

[snouz]

Suggestion: add the ability for a quality to tint items / entity (combined with "draw sprite by default = false", it would give an alternative way to represent quality)

[MrSmoothieHuman]

im not sure if you are still looking for suggestions, but while i was mucking about with reactors i thought of one - maximum_temperature_quality_multiplier?
it'd mutlitplicatively increase the amount of heat a specific entity could have at one moment (if a building can hold 1000 degrees and has a quality mutlipler of 1.5x, it can hold 1500).
I'm not entirely sure how well it'd work in vanilla specifically? since you only get one tier of heat pipe (and i dont expect them to be effected by this, if it was implemented), but it'd be very nice as an option for modders

[braxbro]

im not sure if you are still looking for suggestions, but while i was mucking about with reactors i thought of one - maximum_temperature_quality_multiplier?
it'd mutlitplicatively increase the amount of heat a specific entity could have at one moment (if a building can hold 1000 degrees and has a quality mutlipler of 1.5x, it can hold 1500).
I'm not entirely sure how well it'd work in vanilla specifically? since you only get one tier of heat pipe (and i dont expect them to be effected by this, if it was implemented), but it'd be very nice as an option for modders

This is nice even in vanilla because it increases thermal capacity of reactors & allows for more storage as heat (which is the densest mode of storage in the game iirc) but yeah mods definitely could make good use of this

[braxbro]

Could we get a quality multiplier for a building’s ModuleReceiver base_effects and the ability to turn off the base speed scaling for said buildings?

A planet mod I have planned relies on some crafting machines’ production speeds lining up with the spoil time of planetary products. This essentially limits the amount of non-export resources available to 1 production cycle’s worth, pushing optimization of item lifetime and resource efficiency first and foremost. If these synced buildings were to scale with quality, I would want them to scale innate prod bonuses, not speed, to keep the feel consistent as the player advances on the planet.

[protocol_1903]

Could we get a quality multiplier for a building’s ModuleReceiver base_effects and the ability to turn off the base speed scaling for said buildings?

A planet mod I have planned relies on some crafting machines’ production speeds lining up with the spoil time of planetary products. This essentially limits the amount of non-export resources available to 1 production cycle’s worth, pushing optimization of item lifetime and resource efficiency first and foremost. If these synced buildings were to scale with quality, I would want them to scale innate prod bonuses, not speed, to keep the feel consistent as the player advances on the planet.

I'd recommend that as a crafting machine property, not a quality one, so that mods with very specifically tuned machines (or complex scripting with machines) don't need to interact with the mechanic