[2.0.49] Some recipe-categories are broken

[pepciorek]

From my own testing when making a mod I came across some weird things with recipe-category, then I checked every category and what is a valid target for it, from my findings:

- "advanced-crafting" and "basic-crafting" are the same
- "crafting-with-fluid-or-metallurgy" and "metallurgy-or-assembling" are the same
- "organic-or-assembling" and "organic-or-hand-crafting" are the same
- "electronics-or-assembling" and "electronics-with-fluid" are the same

In the second case "metallurgy-or-assembling" has probably missing [assembling-machine-1] as the target
The third one "organic-or-assembling" has inncorlecty set [character] as valid target
In the fourth case "electronics-or-assembling" has also missing [assembling-machine-1] as the target

category-test.png (87.08 KiB) Viewed 193 times

[boskid]

Thanks for the report however we will not be doing any changes with that data because at this stage of 2.0 development any changes with this could easily be considered as mod breaking. While those recipe categories overlapping in terms of crafters that can use those recipes, this is not strictly a bug and changing it just so it is changed and breaking mods is not something we want to be doing.

As for "metallurgy-or-assembling", in SA it is only used by foundry recipe which needs fluids and assembler-1 does not support fluids.

As for "organic-or-assembling" being present on character, i remember checking this some time ago due to 124649 but i do not remember decisions, definitely not changing it without good reason. That would be a balancing change.

As for "electronics-or-assembling" missing from assembling machine 1, i am not considering this to be a bug, its our decision to say which recipes can be crafted in which machines.

[pepciorek]

"metallurgy-or-assembling" is, from what I see, only used in crafting [foundry], which could be just simplified to "crafting-with-fluid-or-metallurgy", but that would make metallurgy-or-assembling redundant and could free up the spot for a new category with machine-1 as a valid target (it would be like "pressing" without the [character] target). Also, "electronics-or-assembling" is only used to make [electromagnetic-plant], changing that category would mean that electromagnetic plant could be made in assembling machine 1, which I think isn't game-breaking. "electronics-with-fluid" isn't used anywhere from what I can find. If you think that EM plants should stay as assembling-machine-2 and up recipe, it could just be changed to "electronics-with-fluid." As for organic stuff, I think it's alright to not touch this stuff because I imagine it was a pain to balance.