[2.0.45] Inconsistent behavior of filtered pumps between pumping into fluid wagons and pumping into other fluid systems

[cyx2020f]

Reproduction Steps: Please refer to the blueprint exchange at the bottom.

Expected Behavior:
0. When a pump is transferring fluid from one system to another, it should always attempt to empty its contents, even if the filter does not match the remaining fluid in the pump.
1. The pump should also continue attempting to empty its contents when disabled via circuit control.
2. Pumping into a fluid wagon should behave like pumping into a fluid system.

Actual Behavior:
0. When pumping into a fluid wagon, the pump detachs from the wagon and stop pumping when disabled by circuit control. This behavior is expected due to the clear visual animation of detaching.
1. When the filter of a pump attached to a fluid wagon is changed, the pump stops functioning if its current content does not match the new filter setting. However, the pump remains visually attached to the fluid wagon.
2. This behavior itself is inconsistent too: The pump will transfer 20 units of remaining fluid (less if not enough) (1200 units per second → 20 units per tick) into the wagon if the target fluid wagon is empty, no matter what the current filter is. For example, when circuit enabling it, when placing a new fluid wagon, when a new train came into the stop. This can be tested by removing the fluid wagon and rebuilding it again after pasting my test blueprint.

Code: Select all

0eNrNV1GOmzAQvYu/YQUBAkRqT9G/VYQMmMRaYyNjkqYrDtB79GQ9SceGQLrxJiVVtY2igO3xs/1m5nnyinLWkUZSrtDmFdFC8BZtnl9RS3ccM93HcU3QBklMGeodRHlJvqKN328dRLiiipJhhmmcMt7VOZFg4Jxntgrm7vbKNRAOakQLswTX4IAUxLGDTvBMg753rnBWy3EiG04w4WgY7rZKNDaQdAJxYEU8jCHMgA+AcVAhmJDaGn68pzRM9SdJvDj1Yt8Lw3TlJ3HkoB0MOyg3v1jzZdlTuPxssQ0nmnCYKEQtFD2QWyBJr32Hc0YyJna0VbRos+OeQrsWB8ph7xVmLXGQkBTWGlnw/uL0EDiK1EOk0PIyrkTxQpRbdWQIr8EKjHhG+QEWF/I0zJpbvnFN8TJuqdPBm2herDb+ZON77xqtLo22PXyvaV4vd1dqc1e8FCf0rOGTLMexplg64RBGCiVp4RII9t3JBVkgssKFLZqS1YTpoJJKmGlGfejPu6oiMmvpN6IJnT6WxX1vPkWXnzPOslx46wj+LDcV62jpHvHOCjMxET2YA7bFV8sdYdUofxappqtvyBPMf4quaQf1VlKwLCd7fKBDorZEZRVlSuMr2RHrurMQUV5RDmNuQxur172n6LctnCdksJAC2tqL3D5iZTSzIbLQFO6ISTlIcejBqpO6DXC1KLU5Vi4juFXIusdZ5EpS0JJIF6QupxxDKt8Kz/AtU6GdqBE1g7HSIJmTXLZAhCoqW5XNl6M6NXpHBypVh7XDz3FgLFxPSxpss8HSbHODPiF9cYpONZ16e9PeAfsygDWnzChVVklRg0YC0BiqmrUlaFrnbEyvH2Q6+kCmR3I4CIgW8cDz3hD/+T7xRjkukBXB9V3O3+EwvpfJSfxPMjn580xOPiqT0+VyaS17Vt6Dgbr+nwP15/cfi0N1cM9jobq6rNSFBNe6sLUX6xU8Rcw1gzbkB+5FKJjg7G2xJ2XHxn8Wc1Gr29HFuKlESSFkOfJ0VbCbWk5XeVBmaj/yYcNnc6FrPzhUPlSKvpHQoVeXFMChdlKkIY5wWD3tGW5p3wGRDLbOM8Q8vEfn90D3+/odHg7E5/gO/fH8Dv3BdjvUurDV+R+YgxjOoQ6Gqhh6RNmZwutAZGsOFa1XuuKO1kHshUHY978A/viLiA==

[boskid]

I am not considering this to be a bug, quite contrary: if the pump would transfer fluid to a wagon even if the fluid does not match fluid filter, i would consider that behavior to be a bug because if a train would leave while being full and new train would arrive, fluid would be dumped regardless of the fluid filter saying only different fluids should be loaded into a train if a filter is set by control behavior.

[cyx2020f]

I am not considering this to be a bug, quite contrary: if the pump would transfer fluid to a wagon even if the fluid does not match fluid filter, i would consider that behavior to be a bug because if a train would leave while being full and new train would arrive, fluid would be dumped regardless of the fluid filter saying only different fluids should be loaded into a train if a filter is set by control behavior.

I totally agree. Whether dumping mismatched remaining fluid to a wagon is quite subjective, but itself has inconsistencies.

...
2. This behavior itself is inconsistent too: The pump will transfer 20 units of remaining fluid (less if not enough) (1200 units per second → 20 units per tick) into the wagon if the target fluid wagon is empty, no matter what the current filter is. For example, when circuit enabling it, when placing a new fluid wagon, when a new train came into the stop. This can be tested by removing the fluid wagon and rebuilding it again after pasting my test blueprint.
...

If the expected behavior is that mismatched remaining fluid should not be dumped into the wagon, then it should be a bug when pump ignores filter and dumps remaning fluid (for a tick) when the target wagon is empty.

Code: Select all

0eNrlWOFuozgQfhf/hhUOBEKkvae4f1WEDJjUKtjImHSzVR7g3uOe7J7kZgwJ2cZtWq/u9qSLKgrG/jz+Zr7xmBdStiPvtZCGbF+IqJQcyPbhhQxiL1mLbZJ1nGyJZqIlp4AIWfNvZEtPu4BwaYQRfBphH46FHLuSa+gQnEcOBsbuH01oIQLSqwFGKYngiJRF0PdItiHdrE+n4AZp9XEk+j5S7GNT7EJKLkgIJMPBqN4JEy8wAczKpreEtcAvAAWkUq3S2B8u0Zc8yfG32URZHmU0SpJ8RTfZOiB7eB2Q0l4Z8u+wau3DlHN96QfXR//V9WU+/nMibXyYciLlF6RWVapTRhz4+wZFJ1QOK1tetGovBiOqoXh+FPDcqYOQwETD2oEHRGkBs82cRj/BJcjW8G7SqaivVa2qJ27CZuSTuKde0EkWQh5gcqWP06jliVpHV0+zSSOmjlV02p3g75YfGnk4LctdVFP6Qa7p/5Vrn1T5Btc+uTLLnFCJj1VuqLWPVc69gC4pjre8MlpUIYeUtT+GsBly3bDKreP0DJuCE2uhYax9j+SXY9NwXQziO8fIv/xc8y/JrOaVqLkOIaRLIRl4/v2Jky/rH6dOMDak0aotSv7IDmKK3Bm3gHe1xbLhdv0EwdYIPZhi2e7NsUebDkKbkSGxZ75tjzDC0AVDe6atoVvylWApoEbTj+Z17XAH7PcJrD8WNrSLRqsOtABAsyyRt8+goTBcXF+l+7E871IujjeLc104uU8ku4uaJS027Sjq8Jnt37DpAhR7JjPX9D7lWeYsFVZL0unH7v0qKFu9Dl1UjSt2Bw7hIFqDMxg9cufMS44SshES3oW96N2yBdH8aMR5SAFTGSBvuErVz8zY4qXnukIi99ymYsjY0MLMqPmUizpVY3dmwpazwRCnlYm30ONfKPRZmxLUgptOHEWvdP/bfd3byL5CNpx1dyXvlvBq/QlfZ7/M1+l9LeRvaiH5CSlkH00n9B9JJz719BvpJL9HYZpfKIxu04nr2OdVgjqr/Zh6i5n+l8X81x9/flrOk3D85Bx7Vapul1xXqkqDfkNY5ZMzcNJLYkjzG3e4sBOPyEmdBXXsczhHKPDKUD3yemznDy3L2Qef84DSqy72xMIrpevZiTdHcnt4wGMFHEcwyOREwLm7wsMGCKy0p46VVfvcimbNzdlVM5Yy4HcMrPy6Obs0U/u16Bm4xlkeoPSlAVziXYD3cQBbJKzhASoJivfYjk0BqI1O9zHe2/Z0ao93u+kIBStbPmEF5MD1YNe7Tld4aIN/cR6nkGr+Bg+qKgQ=

In this blueprint, both pump stops at the same time, so it shall not transfer more fluid into the wagon. However, pumping fluid out of the wagon makes the left pump empty its contents.