[2.0.43] Crash loading save w/o "planet hoppers" mod (removeEntitiesStagedForDeletion)

[pentaquark]

To repro:
Sync mods with the attached save (or just keep all non-built-in mods disabled, which also results in the same crash)
Disable the "planet hoppers" mod
Try to load the save

This will result in a crash:

Code: Select all

Factorio crashed. Generating symbolized stacktrace, please wait ...
src/Util/StacktraceToStream.cpp (52): walkStackAndPrintToStream
src/Util/StacktraceToStream.cpp (60): printStacktraceToStream
src/Util/Logger.cpp (334): writeStacktrace
src/Util/Logger.cpp (379): logStacktrace
src/Util/CrashHandler.cpp (181): writeStackTrace
src/Util/CrashHandler.cpp (644): commonSignalHandler
src/Util/CrashHandler.cpp (652): SignalHandler
0x7f91192c008f
/opt/gcc-13.2.0/lib/gcc/x86_64-pc-linux-gnu/13.2.0/../../../../include/c++/13.2.0/bits/unique_ptr.h (99): operator()
/opt/gcc-13.2.0/lib/gcc/x86_64-pc-linux-gnu/13.2.0/../../../../include/c++/13.2.0/bits/unique_ptr.h (404): ~unique_ptr
/opt/gcc-13.2.0/lib/gcc/x86_64-pc-linux-gnu/13.2.0/../../../../include/c++/13.2.0/bits/stl_construct.h (88): destroy_at<std::unique_ptr<Entity, std::default_delete<Entity> > >
/opt/gcc-13.2.0/lib/gcc/x86_64-pc-linux-gnu/13.2.0/../../../../include/c++/13.2.0/bits/stl_construct.h (149): _Destroy<std::unique_ptr<Entity, std::default_delete<Entity> > >
/opt/gcc-13.2.0/lib/gcc/x86_64-pc-linux-gnu/13.2.0/../../../../include/c++/13.2.0/bits/stl_construct.h (163): __destroy<std::unique_ptr<Entity, std::default_delete<Entity> > *>
/opt/gcc-13.2.0/lib/gcc/x86_64-pc-linux-gnu/13.2.0/../../../../include/c++/13.2.0/bits/stl_construct.h (195): _Destroy<std::unique_ptr<Entity, std::default_delete<Entity> > *>
/opt/gcc-13.2.0/lib/gcc/x86_64-pc-linux-gnu/13.2.0/../../../../include/c++/13.2.0/bits/alloc_traits.h (947): _Destroy<std::unique_ptr<Entity, std::default_delete<Entity> > *, std::unique_ptr<Entity, std::default_delete<Entity> > >
/opt/gcc-13.2.0/lib/gcc/x86_64-pc-linux-gnu/13.2.0/../../../../include/c++/13.2.0/bits/stl_vector.h (1934): _M_erase_at_end
/opt/gcc-13.2.0/lib/gcc/x86_64-pc-linux-gnu/13.2.0/../../../../include/c++/13.2.0/bits/stl_vector.h (1603): clear
src/Entity/ToDeleteList.cpp (33): clear
src/Map/Map.cpp (1410): removeEntitiesStagedForDeletion
src/Map/Map.cpp (1510): applyStagedChanges
src/Map/MapSetupHelper.cpp (149): MapSetupHelper
src/Map/Map.cpp (856): setupEntities
src/Scenario/Scenario.cpp (292): loadFactory
src/Scenario/ParallelScenarioLoader.cpp (190): doLoad
/opt/gcc-13.2.0/lib/gcc/x86_64-pc-linux-gnu/13.2.0/../../../../include/c++/13.2.0/bits/invoke.h (61): __invoke_impl<void, void (*)(MapInterface, ParallelScenarioLoader *, MapDeserialiser *, InputType, InputSource *, MultiplayerManagerBase *, NamedBool<EnableReplayTag>), MapInterface, ParallelScenarioLoader *, MapDeserialiser *, InputType, InputSource *, MultiplayerManagerBase *, NamedBool<EnableReplayTag>::Enum>
/opt/gcc-13.2.0/lib/gcc/x86_64-pc-linux-gnu/13.2.0/../../../../include/c++/13.2.0/bits/invoke.h (96): __invoke<void (*)(MapInterface, ParallelScenarioLoader *, MapDeserialiser *, InputType, InputSource *, MultiplayerManagerBase *, NamedBool<EnableReplayTag>), MapInterface, ParallelScenarioLoader *, MapDeserialiser *, InputType, InputSource *, MultiplayerManagerBase *, NamedBool<EnableReplayTag>::Enum>
/opt/gcc-13.2.0/lib/gcc/x86_64-pc-linux-gnu/13.2.0/../../../../include/c++/13.2.0/bits/std_thread.h (292): _M_invoke<0UL, 1UL, 2UL, 3UL, 4UL, 5UL, 6UL, 7UL>
/opt/gcc-13.2.0/lib/gcc/x86_64-pc-linux-gnu/13.2.0/../../../../include/c++/13.2.0/bits/std_thread.h (299): operator()
/opt/gcc-13.2.0/lib/gcc/x86_64-pc-linux-gnu/13.2.0/../../../../include/c++/13.2.0/bits/std_thread.h (244): _M_run
/tmp/tmp.dlP10F34z6/objdir/../gcc-13.2.0/libstdc++-v3/src/c++11/thread.cc (104): execute_native_thread_routine
/build/glibc-FcRMwW/glibc-2.31/nptl/pthread_create.c (477): start_thread
__clone
0xffffffffffffffff
Stack trace logging done
  40.628 Error Util.cpp:95: Unexpected error occurred. If you're running the latest version of the game you can help us solve the problem by posting the contents of the log file on the Factorio forums.
Please also include the save file(s), any mods you may be using, and any steps you know of to reproduce the crash.

This save was originally vanilla space age; I recently added a bunch of planet mods to this save, then removed a few planet mods, then tried to remove planet hoppers. Removing the Muluna mod, or the redrawn space connections mod, doesn't cause a crash; I haven't tested removing just a single mod at a time other than that, so I don't know if the issue is specific to planet hoppers or not.

[Loewchen]

127757