[boskid][2.0.21] Locomotives shown heading wrong direction on blueprint when rotated.

[ElderAxe]

Screenshot 2024-11-23 191627.png (2.46 MiB) Viewed 491 times

This is the blueprint for the image above.

0eNrFm2+PmzgQxr9KxGtSYRswrNSTTmr76nQvTnfSSVUUEeKkVgkgcLZdrfLdz+ZPINfd7TNXuvem25DxzzPjMTy7Yx69XXFWdaNL4909envV5o2uja5K78675+xN8CbwfK8ts3ptqvWx0Xtn99W7E9z3Hry75OJ72a6tirNRa2dW6/Lo3ZnmrHxP51XZencfH71WH8uscEPL7KQsu6jy6lQZfa88S9DlXlkmu/hPmB6Ks96vv2RH69Rky29tzUPtbO91Y872ij8O7i3W0WykuGx8T5VGG61677oPD9vyfNqpxroxjTZNpo+fzNr+cNC6anWfnC4H67TLgXXb2+tG5f1XofPsX0gOIyWKFDAyQpEhjBQoMoKRDEXG/lOV8Q0wuPJUme0KtS2qo26Nztvtl0/afj5V912tHrKitcVaNdpOlPWE4A2PnphaotHAwSQoEc54ihLhsmABlnH5EzLO4M0IbxwGb0Z4ezN4MzK4Mhi8GxlcGyzCVtLNvfxSxnBAeGniOxKvD3hPMrxAUizxnP2ExPMADYjD1cnhfcnh6uTwxuRwgXB4Z3K4QPi0M2cy5ltg8qNr6Xt5VVSN4zXdA+3YPVl23f8zh37KO/iRy3H5Am9dgVeQJMqsCGAmRJ2FMFOi0AKYIiAqLYTJiFILYXKK1ooWvWsJQRNbSDghTW0hyIgmtxBkTJFbCydd0uQWEk5Ck1sIMiXKLYAZBkS5hTAZSW4tu5QhJ8otJCBBlFsIMyTKLYQZkeTWwomPiXILCUgS5RbCTIhyC2GmRLkFMKOAIreiV5ZbESPKLSRiTpRbCFMQ5VYKMEOi3EKYEVFuIcyYKLcQpiTKLYSZUORWuuhdK0ppcgsIJw5ocgtBMprcQpCcIreWTXosaHILCSekyS0EGRHlFsKMiXILYUqS3Fp4KROi3EICSolyC2DKgCi3ECYjya1lEy85UW4hAQmi3EKYIVFuIcyIKLcQZkyRW+kryy0piXILiTghyi2EmVKbiAJoFgXUNiICZdRGIgLl1FYiAhXUZiICDUntRLHovSuJiA1FJKCY2FJEmJLYVESYCamruHDiU2JbEQgoDYh9RYTJqI1FBMqpnUUEKmitxWXXMw2pvUUkpIjaXESgMbW7iEAlrb24cPITan8RCSmlNhgFcpIhoLYYISqjNhkhKie1GcUrKzEWCGqjEYo6pLYaIWpElWMSocZUPQZRJVWQQdSEqsggakqVZAgVPXAUTMglTxwxoiiDQuJEVQZBBVGWQdCQpMuWTn5EFGZQSDFRmUFQSZVmEDWhajOImtLE2cKLih9AYoRCxY8gMUKt4IeQGKFYuKAJtKUXIKQqNCioiCrRIGpMlWgQVVIlGkRNSBJNvrZEw88ucUIx46eXxHPVtPG9Nv+k9udiOII/pc99tvUaBb6MfSeCbZZn5l0GVF41++HNgjFL3sd3m9VHbdTprXOqXLemqjerd6quzIqt/7befcm02eZVue987MfbaeusUdvhBYKs3FvD4YMuM+vxvQ3eXdP557a7mV02zv9jU51ra/T+1z9+X61Xf7o57c8Pbnvb+ULPvXBgVNOca9NPNeRsGNAbjsPsAPvvu/Op9txSwy5mZjtmwCfkwi3rS9iyMlt1qm3gLlSTNUdlvsn3BzvH8MLFun/P4u3wukV/j7N0G7FNwWb1V1lU2ZgW6jKMjjhXdNnqvdpeMzvsGBfPd9JLy2tbq1wfdL7dK7tNyy7mrcvK4VwUt6l+Pg3Dj1kefhuz8L0F+Enzz9bhPy3sCxHR17UL5YlE2Nvcy1swCdwe9B8XyMIrVaPdeUX1oJqVqW7uSP//Ts91k5+1mfvibrEH3bR2QvT9Kntzzj+7d6zcG18mc2+TBf4wb2bcc8v7xbt8z5fDWRVbF4tdj3NptllX6j/ilyNOK3/rIH/Cwef3xHNp7pf1/VebwpcqYtOx7aj8syu2sn8UjrPYq917TYemcp6xoC/u7rL7ZXi8bmXALuts5wbRZJCOBreI9GrhlOBgEc0sZpfT2WV3/ncYKOZTislXd8axHyn4zMJdHi2uXt8wwsltd8KrtwjZzGJ2ee6rOyUzDIznU8aTs+4kQD8ySuYW8mohr27fMOTktuuDDhZybnG9LOe+ujbSMDCZT5lMzrq/kPcjk3Bm4S6PFle3bxipnFUGH01ScVMk0/W5t2xePSy8+SacfTPVzW3hzCqn+x1mNLohcTEzSiaj9MZo+oJ3b2C6zWQ31vT+qe8V2U7ZXe31z+7h4T3uMfv9vWrabjtGMU/DNI1CmcpIisvlH5LiisI=

Copy blueprint

It shows the locomotives heading backwards when I take the blueprint and rotate it 180 degrees.

Screenshot 2024-11-23 191457.png (440.01 KiB) Viewed 491 times

[eugenekay]

How are you rotating the blueprint, specifically?

I was not able to reproduce this behavior using the Blueprint String provided, also on 2.0.21, using the R button to Rotate, or Shift-H / Shift-V to flip Horizontal / Vertical.

Screenshot 2024-11-23 121023.png (1.46 MiB) Viewed 481 times

[ElderAxe]

I checked again and noticed that it works when you import the string.

Here it the steps to reproduce:
- Import the string.
- Place the blueprint on to the world
- Create a new blueprint/update existing blueprint with the previously placed tracks including the trains.
- Save the blueprint
- This new blueprint will have this rotating issue.

[robot256]

Confirmed with the new steps on 2.0.21. Note that *placing* the blueprint with backwards-drawn locomotives results in *ghosts* that are rotated correctly, and the locomotives are placed correctly by the bots.

[ElderAxe]

I believe this is same bug as locomotives but wanted to mention this too. This one happens when the train is in stopped position. (Manual or at the station)

Screenshot 2024-12-04 180508.png (260.32 KiB) Viewed 327 times

0eNq9V21r4zAM/ivDn9OjyeL0Be4+7UccjBJcx0vNEjvYTnZl5L+flKRLbldYBaNQSizLjyTrkZDf2bFqVeO0CWz/zrS0xrP98zvzujSiQpkRtWJ75oSuWB8xbQr1h+3j/hAxZYIOWo0nhsU5N219VA4UostJH+BseQqrASJijfVwyhoEB6TVbruJ2Bk+4mzDwUKhnZKjQtpH/wEnH8BSuNKu3kQJqtdgs39glRHHSuWVLbUPWvr87aRhXdtOm5LtX0TlVcSs02BPjEDrHwnHiDsQWQdYpq2qKy49EmLllFhTAvAjBZgTgGMKcHZrdja7e2Vnc3usn5z6ItYtAZhE8R0BmMSneE1AJhEqjm9OfHKvxMcJIVoSy2NCxWckTsWEks9IpIr5rRnK+N0ylBGipTGdUPUZjemEss9orCLUPSexKpnrvrLS1jboTl2F3X5P6qWtrENU+APb5TAPHIdvgcMDkCOoehwcdLEYM6QV45gxbsOuyRc8QvV5BZg+CPk64Erb4hCT9oceflfugDCRcNpEQugznMTihNBnOInFCaHPcBKLE8JskdJYTOgWKS2Dc7dAYLPywTZfwD5+gkUGmuBslR/VSXR65L/UTrY65GMlAdODa6FkLmI4UnxYeNHOh3yevMO5QY867UIrMMpL8IPGygFcP1iFIkDqD0VQN8KJgMbZL9b3Q4WMBtjz0+HhGQvr5xzk4eFJNTY8xKvf7JayrYUBX/IBwOeVrnWYHgNenlTRVtNrYG4zuE7WC4UBX0nriumpQXDwTSwvbTw/xqzy6bqEKUBxWmgjID8d5BplWr56HAvW0CDAodLZtgGlp7auz3BX6GOw8hUNmDGvFw8tNhko8xdn8aYz5NAkzT6kOAMdh3aULPZRelHgF4UlAEonBezTo0IcLzQWYo5e4hWB3/PTLWKdcn64RJ4lUFY7nu6SbZau+/4vlySOvg==

Copy blueprint

Steps to reproduce:
- Place this blueprint.
- Let the train arrive at the station.
- Create a new blueprint with Alt+B and select everything (entities, station, trains, fuel)
- Get the new blueprint at your hand.
- Flip it 180 degrees.

[boskid]

Thanks for the report. This issue is now fixed for 2.0.44.

Being able to reproduce this was really helpful as this is what allowed me to identify root of the issue. Rolling stocks can have their position and orientation set by 2 competing means: one is by position of front and back joints, and second is by the entity's position and orientation. Blueprint preview was correctly setting the locomotive's orientation but the issue was that this locomotive also had joints attached to the underlying rails and drawing takes orientation based on joints position as a priority. When joints are exactly overlapping, the resulting orientation happened to be east. Those locomotives are placed exactly so that they span 2 full rails and joints(wheels) are exactly at the far edges of 2 rail pieces, however when blueprint was rotated, since horizontal and vertical rails keep their direction while rails relative position swaps, 2 joints that were far apart now tried to render on the same screen position. You may actually notice this artifact if you look closely: in the faulty case, every second fluid wagon has traces of wheels rendering exactly in the center of a rolling stock, and other half has wheels at the correct position because they happened to be exactly on the center of the rails where the blueprint rotation does not affect them. This also explains the other cases where rolling stocks are inconsistently shifted forward and backward and they are also fixed here. Fix is basically that when rolling stock is asked to change its orientation, that means the orientation should be now used when drawing (not the joints) so i detach such rolling stock from rails and this fixes the problem.