[MOD 0.10.x] Time Display - v1.0.0

[FreeER]

Here's my updated version for 11.x MP, note I haven't tested this in MP or with prior saves so... if something happens let me know (with the error message)

script commands updated to take the nickname (in "quotes") as the last parameter so that settings can be separate for each player.

note: double post is so that people subscribed to the topic will be notified of this post, editing my previous one wouldn't notify them.

[FishSandwich]

New error, both MP and SP maps.

Code: Select all

Error while running the event handler
__TimeDisplay__control.lua:159:attempt to index field '?' (a nil value)

[FreeER]

New error, both MP and SP maps.

Hm, I didn't encounter that myself... I added a couple checks for what I assume happened there (that ontick got called when there was a player without any TD settings, not much else could happen there but I wouldn't have expected that since default settings are applied to during player creation and for all players during onload) and a fix for an error I noticed when I loaded a save (that didn't have the mod). download (last download link would also work since I updated Dropbox)

[FishSandwich]

Hmm, no error, no crash, but the clock doesn't show on MP saves. :/

Edit: Works on new games created in multiplayer.

[FreeER]

Hmm, no error, no crash, but the clock doesn't show on MP saves. :/
Edit: Works on new games created in multiplayer.

Right... I thought about that as soon as I made made the post and tried to change it before anyone noticed just to make sure this is line 159 of the one I first did

Code: Select all

if glob[player.name] and glob[player.name].minute_rounding and
    (event.tick % (UPDATE_INTERVAL * glob[player.name].minute_rounding) == 0) then 

then I updated dropbox to use this instead

Code: Select all

    if not glob[player.name] then
      set_defaults(playerindex)
      init_gui(playerindex)
    end

If you have the first then redownload (or do so anyways if you want) and try again, IF the 'updated' one still doesn't work then try enabling it via script the interface and let me know if that works.

Code: Select all

/c remote.call("TimeDisplay", "SetSetting", "enabled", true, "nickname")

edit: it seems like onload isn't working as desired for mp saves (ie, that the game.players list is empty during the event so the gui and settings aren't set properly)

[FishSandwich]

Okay so, it works fine when I use the remote.call, but after a few seconds the clock disappears again.

[FreeER]

Okay so, it works fine when I use the remote.call, but after a few seconds the clock disappears again.

I was afraid that might happen, onsave it's setup to remove the gui (so that if the mod is removed it doesn't leave the gui behind with no way to remove it except manual game commands), if onload isn't working then it doesn't bring it back up properly.
I made a further alteration in ontick to check for the gui actually being onscreen, if that for some reason isn't working for you then try removing the game.onsave code so that the gui isn't removed, if that doesn't work then I'm afraid I'll have to ask one of the other experts who can do proper testing to solve this. download, again

[FishSandwich]

try removing the game.onsave code so that the gui isn't removed

That worked. Thanks FreeER.

[FreeER]

try removing the game.onsave code so that the gui isn't removed

That worked. Thanks FreeER.

Glad I could help Sorry it took so long

For everyone who comes across this here's the download link with all of the changes made (all the previous ones I posted should work too, but people tend to jump to the end so...) including commenting out game.onsave.

to manually remove the gui (in case you forgot to disable it before removing the mod and don't want to reinstall the mod just to disable it), note this is also listed in the control.lua file (just search for 'manually remove' or 'game.onsave' and you'll find it). Also, all script interface commands are correctly commented at the end of the file as they were originally (updated to show that the nickname is also needed)

removal code

In singleplayer use:
/c for _, location in ipairs({"center", "top", "left"}) do if game.player.gui[location].dark_game_clock then game.player.gui[location].dark_game_clock.destroy() end end

In multiplayer use this:
first change my_nick to whatever your multiplayer nickname is however!

/c for index, player in pairs(game.players) do if player.name == "my_nick" then for _, location in ipairs({"center", "top", "left"}) do if player.gui[location].dark_game_clock then player.gui[location].dark_game_clock.destroy() end end end end

edit: actually it wouldn't matter (considering use case) and might even be better if that affected all players in multiplayer, here's one that would:
/c for index, player in pairs(game.players) do for _, location in ipairs({"center", "top", "left"}) do if player.gui[location].dark_game_clock then player.gui[location].dark_game_clock.destroy() end end end

[FishSandwich]

Ack, my bad, premature celebrations here. ;_;

So, the clock still disappears with game.onsave commented out. I tried commenting out game.onload as well, and now it works as expected, but still need to use the remote.call

[delfiler]

can i add your mod to a modpack?

[kovarex]

I was managing this bug report https://forums.factorio.com/forum/vie ... =29&t=8806
You could take a look at it

Just a notice, I made it clear, that you should never do the stuff you are doing in the onsave method, it can break a lot of stuff, I even added warning in the wiki.
https://forums.factorio.com/wiki/inde ... ame.onsave

[Mr. Thunder_Tw]

from kovarex

Just a notice, I made it clear, that you should never do the stuff you are doing in the onsave method, it can break a lot of stuff, I even added warning in the wiki.

I've also made a mod that does something similar though as an option that's off as default.
In case of some mod-switching after saving, when a mod has gui open, and mod turned off, there's no way to remove it...
>> onSave-gui-removing hase this fixed (that's why i found it somewhat usefull during development testing and it works in sp, mp not tested)

[dragon011]

How can I disable this time 07:41:43

Did the commands entered into the console Can you post what i copy must

[Peter34]

This mod doesn't work. When I try to start Factorio, with the .zip file in my Mods folder, I get an error box popup saying something about a case-sensitive problem. When I delete the .zip file, Factorio starts up fine.

[PurpleFrog]

The internal mod is expecting TimeDisplay_v1.0.0.zip as the file name. It currently downloads as TimeDisplay-v1.0.0.zip. If you change the dash to an underscore, the mod loads just fine.

[FishSandwich]

This mod doesn't work. When I try to start Factorio, with the .zip file in my Mods folder, I get an error box popup saying something about a case-sensitive problem. When I delete the .zip file, Factorio starts up fine.

This version of the mod is the most up to date.