[2.0.34] "virtual-signal=signal-ghost" is gone without migration

Bugs that are actually features.
Post Reply
Copy link
User avatar
Hares
Filter Inserter
Filter Inserter
Posts: 653
Joined: Sat Oct 22, 2022 8:05 pm
Contact:
Contact Hares

[2.0.34] "virtual-signal=signal-ghost" is gone without migration

Post by Hares »

Steps to Reproduce
  1. Make a circuit containing [virtual-signal=signal-ghost] in 2.0.33
  2. Update to 2.0.34
  3. Load that save
Expected:
  • Migration dialog pops up
  • Everything works as before
  • Recycling recipes removed
Actual:
  • Migration dialog pops up
  • Recycling recipes removed
  • Virtual signal: ghost not mentioned yet removed
02-09-2025, 18-34-40.png
02-09-2025, 18-34-40.png (66.51 KiB) Viewed 338 times
See Also
Attaching a savefile with mentioned problem.
Where to find the problematic circutis:
  • Gleba, jellynut plantation (8 hours from the spawn), train stop "[item=jellynut] Cargo / Load"
  • Gleba, yumako plantation (3 hours from the spawn), train stop "[item=yumako] Cargo / Load"
Attachments
16 - Fixed train stop designs.zip
(59.61 MiB) Downloaded 7 times
Top
User avatar
Hares
Filter Inserter
Filter Inserter
Posts: 653
Joined: Sat Oct 22, 2022 8:05 pm
Contact:
Contact Hares

Re: [2.0.34] "virtual-signal=signal-ghost" is gone without migration

Post by Hares »

Attaching minimalistic non-SA savefile with the mentioned problem (created on 2.0.32 - latest stable):
  • Load on 2.0.32 - Works fine, no alerts
  • Load on 2.0.34 - Signal is gone w/o any migration popup, alert is fired
Attachments
bug-126713-ghost-signal.zip
(398.48 KiB) Downloaded 8 times
Top
Rseding91
Factorio Staff
Factorio Staff
Posts: 14925
Joined: Wed Jun 11, 2014 5:23 am
Contact:
Contact Rseding91

Re: [2.0.34] "virtual-signal=signal-ghost" is gone without migration

Post by Rseding91 »

Thanks for the report. Virtual signals do not get a popup migration message (not everything does). The "signal-ghost" was removed because the signal entity-ghost is identical.
If you want to get ahold of me I'm almost always on Discord.
Top
User avatar
Hares
Filter Inserter
Filter Inserter
Posts: 653
Joined: Sat Oct 22, 2022 8:05 pm
Contact:
Contact Hares

Re: [2.0.34] "virtual-signal=signal-ghost" is gone without migration

Post by Hares »

Rseding91 wrote: Sun Feb 09, 2025 4:40 pm Thanks for the report. Virtual signals do not get a popup migration message (not everything does). The "signal-ghost" was removed because the signal entity-ghost is identical.
However, this causes signals to disappear. Migration is required when making a breaking changes. Removal of the mentioned signal caused my Gleba base to blackout.
Top
Rseding91
Factorio Staff
Factorio Staff
Posts: 14925
Joined: Wed Jun 11, 2014 5:23 am
Contact:
Contact Rseding91

Re: [2.0.34] "virtual-signal=signal-ghost" is gone without migration

Post by Rseding91 »

I’ve forwarded this to the person who merged the PR. The PR said to specifically remove this signal because the icon was the same as the entity ghost one - and so the people working on it did.

But of course this did what you’ve served and it no longer exists in saves because the icon isn’t actually used anywhere except rendering - internally it’s all different between the signals.
If you want to get ahold of me I'm almost always on Discord.
Top
User avatar
Hares
Filter Inserter
Filter Inserter
Posts: 653
Joined: Sat Oct 22, 2022 8:05 pm
Contact:
Contact Hares

Re: [2.0.34] "virtual-signal=signal-ghost" is gone without migration

Post by Hares »

For those who wonder: this JSON migration placed within your game folder works fine (keeps achievements ON)

Should be placed in data/base/migrations/

Code: Select all

{
    "virtual-signal":
    [
        [ "signal-ghost", "signal-hourglass" ]
    ]
}
This will replace all removed signals with the new hourglass signal, so no conflicts should be there.
Automatic migration to entity-ghost, unfortunately, is not possible.

Also note that this would only work if the savefile didn't run on 2.0.34, so you must rollback to earlier save.
Top
Muche
Filter Inserter
Filter Inserter
Posts: 792
Joined: Fri Jun 02, 2017 6:20 pm
Contact:
Contact Muche

Re: [2.0.34] "virtual-signal=signal-ghost" is gone without migration

Post by Muche »

As a consequence of the removed virtual ghost signal, an imported blueprint containing it will skip entities referencing it.

(Just noting for SEO / reference.)
Top
Post Reply

Return to “Not a bug”