[2.0.25] Data JSON dump recycling recipes missing subgroup

Bugs that are actually features.
ilbJanissary
Inserter
Inserter
Posts: 40
Joined: Tue May 28, 2019 12:34 pm
Contact:

[2.0.25] Data JSON dump recycling recipes missing subgroup

Post by ilbJanissary »

Running --data-raw-dump on version 2.0.25, the resulting JSON data seems to be missing the subgroup field on recycling recipes. This field was present in the dump from 2.0.24 (the value was "other").
User avatar
xargo-sama
Long Handed Inserter
Long Handed Inserter
Posts: 60
Joined: Mon Jun 05, 2023 1:04 pm
Contact:

Re: [2.0.25] Data JSON dump recycling recipes missing subgroup

Post by xargo-sama »

Hello,

This is not a bug. Categories of recycling recipes (which were previously hidden from Factoriopedia) are changed to match their item counterpart. This improves navigation through tabs significantly.
ilbJanissary
Inserter
Inserter
Posts: 40
Joined: Tue May 28, 2019 12:34 pm
Contact:

Re: [2.0.25] Data JSON dump recycling recipes missing subgroup

Post by ilbJanissary »

I don't think I understand. Your replies seem to say "the subgroup is now the subgroup of the item being recycled", but the issue I am seeing is there is no subgroup assigned to the recipes at all.

Is it because the subgroup is not assigned until a later point in the game startup process now, and it isn't assigned until after the stage at which the game runs the dump data command?

The code change you linked implies that if there is no subgroup on the recipe, it will use the subgroup of the main product. That's great, that's perfect, that's exactly what my code expects to happen, there's just one problem. The data dump doesn't include a main product on the recipe either.
12-13-2024, 08-48-36.png
12-13-2024, 08-48-36.png (28.28 KiB) Viewed 250 times
Last edited by ilbJanissary on Fri Dec 13, 2024 1:48 pm, edited 1 time in total.
Rseding91
Factorio Staff
Factorio Staff
Posts: 14896
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: [2.0.25] Data JSON dump recycling recipes missing subgroup

Post by Rseding91 »

Subgroup is optional and if not defined will take the subgroup of the recipe main product of it doesn't have one will default to "other". This logic happens on the engine side after data.raw parsing.
If you want to get ahold of me I'm almost always on Discord.
ilbJanissary
Inserter
Inserter
Posts: 40
Joined: Tue May 28, 2019 12:34 pm
Contact:

Re: [2.0.25] Data JSON dump recycling recipes missing subgroup

Post by ilbJanissary »

OK - So just to make sure then, since these recipes have no main product and no subgroup, I should assume their subgroup is "other".
I can do that, it just didn't sound like that was the intent from the first two replies.
Post Reply

Return to “Not a bug”