[2.0.24] Blueprint parameter value is not applied to tokens in currently-disabled control behavior settings

Bugs that are actually features.
User avatar
Hares
Filter Inserter
Filter Inserter
Posts: 857
Joined: Sat Oct 22, 2022 8:05 pm
Contact:

[2.0.24] Blueprint parameter value is not applied to tokens in currently-disabled control behavior settings

Post by Hares »

If you have {0}, {1}, or other tokens in your blueprint and you deploy it with values for these tokens set, ones behind disabled control behavior are not applied.
Token values not set
Token values not set
12-11-2024, 19-20-23.png (155.13 KiB) Viewed 356 times
Token values set
Token values set
12-11-2024, 19-20-40.png (166.95 KiB) Viewed 356 times
Click to expand the recording
Blueprint:
Attachments
2024-12-11 19-17-00.mp4
(7.04 MiB) Downloaded 25 times
Fulgora is the best planet. Vulcanus needs rework. Feel free to prove me wrong.
User avatar
boskid
Factorio Staff
Factorio Staff
Posts: 4151
Joined: Thu Dec 14, 2017 6:56 pm
Contact:

Re: [2.0.24] Blueprint parameter value is not applied to tokens in currently-disabled control behavior settings

Post by boskid »

You are absolutely right. Works as intended.

-- edit:

Related 123321
User avatar
Hares
Filter Inserter
Filter Inserter
Posts: 857
Joined: Sat Oct 22, 2022 8:05 pm
Contact:

Re: [2.0.24] Blueprint parameter value is not applied to tokens in currently-disabled control behavior settings

Post by Hares »

boskid wrote: Wed Dec 11, 2024 6:29 pm You are absolutely right. Works as intended.

-- edit:

Related 123321
So I was right thinking that behaved diffrently on previous versions...

I still would treat the current behaviour (described in topic) as:
  • visually annoying
  • inconsistent
  • counter-intuitive
  • potentially-breaking (see below)
I would suggest hiding (or not-parameterizing) only signals that are invisible on current UI, or if a parameter is a parameter template, always render its value despite wherever it is.

Why so?
Imagine you have a train stop template. You are selecting item type in the pop-up, and deploy it. The train stop is currently configured:
  • Name: "{0} Load"
  • Enabled condition: Active; {0} > 0
  • Train limit (static): Active; 1
  • Train limit (dynamic): Disabled; {0}
  • Priority (static): Disabled
  • Priority (dynamic): Active; {0}
12-11-2024, 22-17-17.png
12-11-2024, 22-17-17.png (50.99 KiB) Viewed 299 times
12-11-2024, 22-17-31.png
12-11-2024, 22-17-31.png (36.84 KiB) Viewed 299 times


After deploying a train stop, you can check one box to enable dynamic train limit (because this one is located far enough so restricting it with one approaching train will reduce throughput significantly. And that how it worked on 2.0.23. However, on 2.0.24, after deploying, for example, it with {0}="iron ore" you end up with:
  • Name: "<iron ore> Load"
  • Enabled condition: Active; iron ore > 0
  • Train limit (static): Active; 1
  • Train limit (dynamic): Disabled; "{0}"
  • Priority (static): Disabled
  • Priority (dynamic): Active; iron ore
12-11-2024, 22-17-43.png
12-11-2024, 22-17-43.png (40.56 KiB) Viewed 299 times
So the use-case I described above is no longer working. Yes, you could argue that you can instead use any other static signal, like N, or L, but that only masks the problem, and does not solve it.
Fulgora is the best planet. Vulcanus needs rework. Feel free to prove me wrong.
User avatar
boskid
Factorio Staff
Factorio Staff
Posts: 4151
Joined: Thu Dec 14, 2017 6:56 pm
Contact:

Re: [2.0.24] Blueprint parameter value is not applied to tokens in currently-disabled control behavior settings

Post by boskid »

It is working as intended to avoid noise on the parametrisation gui with unrelated signals. I will not be adding any weird exceptions based on visibility in the gui to have "not collect, not apply" (for not visible signals), "not collect but apply" (for disabled but visible), "collect and apply even if disabled" or "collect and apply when parameter but do not collect nor apply when not a parameter". There are no bugs in this report so there is nothing to fix, if you want to suggest some changes, there is ideas and suggestions subforum.
Locked

Return to “Not a bug”