[2.0.21] "quality" missing from migrations json list

warbob5000
Burner Inserter
Burner Inserter
Posts: 5
Joined: Wed Nov 20, 2024 6:35 pm
Contact:

[2.0.21] "quality" missing from migrations json list

Post by warbob5000 »

The list for JSON migrations does not list "quality" as an available type.
Rseding91
Factorio Staff
Factorio Staff
Posts: 15884
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: [2.0.21] "quality" missing from migrations json list

Post by Rseding91 »

I think the list could be simplified by just deleting it and saying "all prototype types support migrations"
If you want to get ahold of me I'm almost always on Discord.
warbob5000
Burner Inserter
Burner Inserter
Posts: 5
Joined: Wed Nov 20, 2024 6:35 pm
Contact:

Re: [2.0.21] "quality" missing from migrations json list

Post by warbob5000 »

That's probably a better idea - context of my request was I had a mod adding extra qualities, and eventually wanted to revert to standard. I'm new to Factorio modding itself but I've made a few mods for other games so checked documentation, saw that migrations had a long list but not the one I wanted, and so started trying to code a lua migration with some help from the Discord's #mod-dev-help - one of them suggested I try a json migration anyway, which turned out to work. One of the people helping me suggested I make a doc improvement request.

I think it's fine to keep the list as long as it's specified it's not an exhaustive one. The way it's currently worded implies that only those listed types are available. If indeed "all prototype types" are supported then perhaps an idea would be to link to the Prototypes page?
curiosity
Filter Inserter
Filter Inserter
Posts: 668
Joined: Wed Sep 11, 2019 4:13 pm
Contact:

Re: [2.0.21] "quality" missing from migrations json list

Post by curiosity »

warbob5000 wrote: Mon Nov 25, 2024 3:13 pm I think it's fine to keep the list as long as it's specified it's not an exhaustive one.
That's against the spirit of having documentation.
Bilka
Factorio Staff
Factorio Staff
Posts: 3421
Joined: Sat Aug 13, 2016 9:20 am
Contact:

Re: [2.0.21] "quality" missing from migrations json list

Post by Bilka »

I've updated the list for the next version.
I'm an admin over at https://wiki.factorio.com. Feel free to contact me if there's anything wrong (or right) with it.
Post Reply

Return to “Resolved Requests”