[StrangePan][2.0.21] Replacing ghost with different quality changes orientation (mirroring)

[Linsanga]

If you have a quality building as your cursor, and you click on a mirrored ghost building (to replace it with your selected quality), the building changes orientation.

ghostmirror.png (1.69 MiB) Viewed 1136 times

Steps to reproduce:
1. Create a set of mirrored and unmirrored building ghosts, like in the picture (EM plant, chemplant, and refinery all reproduce the bug).
2. Put a quality version of the building on your cursor.
3. Either click and drag the cursor across the ghosts, or click on each ghost (to replace the ghost with a quality version of the ghost)

Behavior:
The mirroring is undone, all buildings have the same orientation after replacing them with quality.

Note:
If you replace quality of real buildings (not ghosts) in the same way, it will behave correctly and keep the correct orientation.

Expected:
The building keeps its orientation, the only thing that happens is the quality changes.

[Linsanga]

This also incorrectly resets the orientation when placing physical machines over ghosts: if you have a line of ghosts where half are mirrored, then you run down the line physically placing machines (with a higher quality) over the ghosts, they will all be oriented the same way once you are done. But it knows to keep the recipe.

[posila]

Thanks for the report.
This is currently intended behavior. When building over ghosts, it mirroring and orientation is taken from the cursor. Recipe is copied from the previous ghost, as it's not possible to set recipe for item in cursor (unless it's blueprint, in which case cursor also wins)

[Linsanga]

When building over ghosts, it mirroring and orientation is taken from the cursor.

This is not true: when I build a normal quality building over a normal quality ghost, the mirroring is taken from the ghost, not the cursor. It only forgets to take mirroring from the ghost when using quality. This is better illustrated with the example in the below picture.

The decisions about when to take mirroring from the cursor vs from the ghost make perfect sense, for normal quality. But when placing different quality, it starts to use different decisions about where to pull that info from.

quality.png (725.79 KiB) Viewed 1004 times

[posila]

Moved back to bug reports for re-evaluation.

[StrangePan]

Thanks for the report! It seems that there were a few places that were affected by this bug. It will be fixed in 2.0.25.