Hi! I propose that a new prototype (likely abstract) be added called "EntityWithInventoryPrototype". It would be a simple entity prototype with an inventory. It would have some properties that ContainerPrototype has right now, such as inventory_size, inventory_type and quality_affects_inventory_size (mainly this one) and both ContainerPrototype and VehiclePrototype would inherit from it. VehiclePrototype would have an option to disable/enable the inventory, and you can work out what happens to the children prototypes of RollingStockPrototype.
The main reason for this request (for inventories to be separated from cargo wagons and containers) is so that CargoWagonPrototype can have the quality_affects_inventory_size property.
"EntityWithInventoryPrototype"
-
BraveCaperCat
- Filter Inserter
- Posts: 412
- Joined: Mon Jan 15, 2024 10:10 pm
- Contact:
"EntityWithInventoryPrototype"
Creator of multiple mods, including Quality Assurance - My most popular one.
Go check them out with the first and second links!
I'll probably be wanting or giving help with modding most of the time I spend here on the forum.
Go check them out with the first and second links!
I'll probably be wanting or giving help with modding most of the time I spend here on the forum.
Re: "EntityWithInventoryPrototype"
Why not just request that we add quality support for cargo wagons as a modding option? That would be *way* simpler than what you suggest 
If you want to get ahold of me I'm almost always on Discord.
-
BraveCaperCat
- Filter Inserter
- Posts: 412
- Joined: Mon Jan 15, 2024 10:10 pm
- Contact:
Re: "EntityWithInventoryPrototype"
Yes, but at least this way it's consistent with existing prototypes. (Looking at you, EntityWithHealth and EntityWithOwner Prototypes!)Rseding91 wrote: Tue Nov 19, 2024 11:40 pm Why not just request that we add quality support for cargo wagons as a modding option? That would be *way* simpler than what you suggest
Creator of multiple mods, including Quality Assurance - My most popular one.
Go check them out with the first and second links!
I'll probably be wanting or giving help with modding most of the time I spend here on the forum.
Go check them out with the first and second links!
I'll probably be wanting or giving help with modding most of the time I spend here on the forum.
Re: "EntityWithInventoryPrototype"
Why not then add it for every entity type with inventory? The end result would be indistinguishable.Rseding91 wrote: Tue Nov 19, 2024 11:40 pm Why not just request that we add quality support for cargo wagons as a modding option? That would be *way* simpler than what you suggest
Re: "EntityWithInventoryPrototype"
Because it takes developer time and energy to make tests for, implement, and then maintain it everywhere and there are currently 23 pages of bug reports to work oncuriosity wrote: Wed Nov 20, 2024 1:06 am Why not then add it for every entity type with inventory? The end result would be indistinguishable.
If you want to get ahold of me I'm almost always on Discord.
-
BraveCaperCat
- Filter Inserter
- Posts: 412
- Joined: Mon Jan 15, 2024 10:10 pm
- Contact:
Re: "EntityWithInventoryPrototype"
Which is better? An update fixing 20 bugs, or an update fixing 15 bugs as well as adding 1 (minor) feature?Rseding91 wrote: Wed Nov 20, 2024 1:13 amBecause it takes developer time and energy to make tests for, implement, and then maintain it everywhere and there are currently 23 pages of bug reports to work oncuriosity wrote: Wed Nov 20, 2024 1:06 am Why not then add it for every entity type with inventory? The end result would be indistinguishable.
Creator of multiple mods, including Quality Assurance - My most popular one.
Go check them out with the first and second links!
I'll probably be wanting or giving help with modding most of the time I spend here on the forum.
Go check them out with the first and second links!
I'll probably be wanting or giving help with modding most of the time I spend here on the forum.