[2.0.15] Prod + Quality synchronization

[Hares]

If you insert quality modules into +50% or +100% prod assembler, every 2nd or every 1st crafting cycle the result is doubled. The second result from prod bonus is the exact copy of the previous one - at least in terms of quality; I've watched Foundry working for several minutes. It looks like this has something to be done with the fact results are triggering on the same tick and the quality result "RNG" is tick-based.

[boskid]

And where is a bug?

[Hares]

And where is a bug?

It's really strange to see multiple high-quality items to go in a row, which should be very unlikely - to a "statistically impossible" unlikely. My suggestion is to add machine's "Products finished" metric to the tick to shift the generator.

For example, you are crafting copper wire in EM plant that has a single T1Q3 quality module (+1.6%) and single T2 speed module (-1.5%), resulting in 0.1% chance of getting higher-tier item, or 1e-3. Probability to get two higher-tier items is 1e-6 which is very unlikely but possible. Let's assume you managed to hit that chance and you finally get your Q3 copper wire. And what do you see? The second Q3 copper wire! The odds of that happening should be 1e-12 but you actually got it for free.

Edit: Added math.
Edit #2: Homework: Using diminishing-returns beacons of different quality, find the lowest possible positive quality bonus.

[boskid]

I am still not seeing any bugs here. You are right saying that it is unlikely to see multiple high quality items to go in a row and that is true, bonus craft gives items of the same quality as the main craft will give which is caused by the quality roll being performed when ingredients are consumed. For the entire duration of the main craft, every bonus craft will get the same quality. However i am not seeing this to be anything wrong. In long run distribution of qualities of the bonus items will go towards the same distribution as the main recipe since they are generated using the same roll. I could even risk saying that the current behavior is the good one because by having bonus products of the same quality, they are more easily insertable into the results inventory without blocking the machine to stop crafting until incompatible items are removed so this improves throughput, and i know at least couple of players that will not hesitate to create bug reports because assembling machines show a sign of a downtime.

[computeraddict]

Does the higher quality result still come out if you pause the craft (say, by removing power), remove all of the quality modules, fill with enough productivity to force a bonus before the next main product finishes, then resume crafting?

[Hares]

I am still not seeing any bugs here. You are right saying that it is unlikely to see multiple high quality items to go in a row and that is true, bonus craft gives items of the same quality as the main craft will give which is caused by the quality roll being performed when ingredients are consumed. For the entire duration of the main craft, every bonus craft will get the same quality.

So, inserting quality modules after you started crafting your power armor is a bad habit, got you.

[Hares]

Does the higher quality result still come out if you pause the craft (say, by removing power), remove all of the quality modules, fill with enough productivity to force a bonus before the next main product finishes, then resume crafting?

Imagine a factory.

Crafting machine is in its separate power grid with a single solar panel on Aquilo, connected to the main grid via power switch. Machine is loaded with 8x T3Q5 quality modules, then the ingredients are loaded, and when they done & machine started sending "Working" signal (at abysmal almost 0.000...001% speed due to the power outage), you pause the craft, then tell Recursive Blueprints to update the modules with 8x T3Q5 prod, then you connect the power and wait for the first extra product to come out. Then, you pause the production, disconnect the main power network, and super-force paste the empty assembler ontop of it (again, via Recursive Blueprints) to reset the recipe before the crafting cycle is complete. Then repeat. It's like 3D-printing from the other thread but with quality modules!

P.S.
Dosh, you know what to do.