[boskid][2.0.11] Recipes with only liquid output allow Quality modules

[Mefisto1029]

There is more recipes where the quality can be used for the production of only liquid:
Fluoroketone hot and cold
Electrolite
Rocket fuel/oxidizer (all four recipes)
Liquid iron/coper
Ice melting
Liquid holmium
Acid

[boskid]

I made a test to find all recipes that match this conditions and there are following recipes for which quality modules do not make any sense:
- acid-neutralisation
- advanced-thruster-fuel
- advanced-thruster-oxidizer
- biolubricant
- coal-liquefaction
- electrolyte
- fluoroketone
- fluoroketone-cooling
- holmium-solution
- ice-melting
- molten-copper
- molten-iron
- simple-coal-liquefaction
- sulfuric-acid
- thruster-fuel
- thruster-oxidizer

I am hesitating about disallowing quality modules because that has a consequences when an assembling machine's "Set recipe" from circuit network is used, because if a recipe is selected that does not allow given modules, then those modules will be ejected from the assembler to the dump inventory.

[boskid]

For now a decision was made that we will keep quality modules allowed on those recipes. I know of some recipes that do not allow quality effect because they would be significantly broken in such case (if they have catalysts like kovarex-enchriment-process, barreling or fish breeding) but on those recipes the quality modules effectively do nothing. Primary issue with having too strong module limitations here is that when using assembling machine's "Set recipe" from circuit network, if a recipe is set that does not allow for modules the machine has in a given point in time, then the modules will get ejected to the dump inventrory and there are no ways of automatically reinsert them to the machine.

As of this decision, i am moving this bug report to Wont fix, however if a different decision would be made in future then i will restore this topic.

[IsaacOscar]

For anyone else who came to this bug report confused about quality modules on fluids, I wrote a lua script to try and work out what the rules are, and this is what I came up with for fluids:

1. If the recipe's ingredients and outputs are all fluids, quality modules are not allowed
2. The only exception to the above is "Cooling hot fluoroketone" (which is made in a Cryogenic Plant)
3. If the recipe can only been made in an Oil Refinery, quality modules are not allowed (this includes Coal Liquefication" and "Simple Coal Liquefication")
4. Otherwise, quality modules are allowed (i.e. Cooling hot fluoroketone, and non-coal-liqueficiation fluid recipes that have at least one non-fluid ingredient or output)

Personally I find this behaviour to be rather arbitrary and inconsistent, especially when compared to productivity modules which also have the same issue with set-recipe.

Oh and the only other recipes not allowing quality are:

1. Rocket Parts
2. Kovarex enrichment process
3. Biter eggs and Nutrients from bitter egg
4. Fish breeding and nutrients from fish
5. Research in Labs and Bio Labs

(Everything else allows quality modules).