[2.0.10] Effect Preview Uses Current Bonuses Instead of Expected Bonus

[b_______]

Technologies that provides a bonus to a stat (such as damage), show how much more will be applied (+10%) but also show what the total effect is before and after the technology is researched (+0% -> +10%). However, after the technology is researched, the preview of the total effect has the bonus applied again as if the technology can be researched again (+10% -> +20%).

This is most obvious with "Steel axe" but can be seen in other research too:

Factorio Bug 1.png (68.49 KiB) Viewed 239 times

Should say: [+0% -> +100%]

Factorio Bug 2.png (140.86 KiB) Viewed 239 times

Should say: [+0% -> +10%]

The preview works correctly for technology that is available to be researched:

Factorio Bug 7.png (148.75 KiB) Viewed 239 times

Future Technologies

Additionally, future technologies that are part of a series (numbered technologies) show the preview with the current total effect bonus, even though there will already be additional bonuses applied by the time that technology is available to be researched. For example, the first, second, and third "Laser weapons damage" applies bonuses of +20%, +20%, and +30% respectively. The previews should show [+0% -> +20%], [+20% -> +40%], and [+40% -> +70%]. This relays what the bonus will be before and after each technology is researched. However the previews show: [+0% -> +20%], [+0% -> +20%], and [+0% -> +20%] as seen below:

Factorio Bug 4.png (106.94 KiB) Viewed 239 times

Factorio Bug 5.png (109.72 KiB) Viewed 239 times

Should say: [+20% -> +40%]

Factorio Bug 6.png (108.84 KiB) Viewed 239 times

Should say: [+40% -> +70%]

Explanation and Proposed Fix

What is happening is that the preview takes whatever the current total bonus is and used that to show what the effect would be after the technology is researched. It should actually use what the total bonus would be at the time of research, whether past or future. This shouldn't be an issue because there are no parallel technologies that apply the same bonus, only technologies that are dependent on each other (series). It should be trivial to pre-calculate all of the expected bonuses throughout the tech tree at the beginning of the game instead of dynamically updating the preview with the current bonuses as research is completed.

[cs278]

Came here to report the same thing, thought I was going mad trying to see what the maximum damage buff was. As you can see the 40->60 is displayed for n+1 and n+2 technologies.

10-24-2024, 23-37-45.png (98.43 KiB) Viewed 194 times

10-24-2024, 23-38-14.png (99.13 KiB) Viewed 194 times

[boskid]

Duplicate 116018.