[2.0.7] Crash when clicking mod dependency not in filtered mod list (ModInfoPane::showModRelease)

This subforum contains all the issues which we already resolved.
MBGames
Burner Inserter
Burner Inserter
Posts: 5
Joined: Mon Oct 21, 2024 2:05 pm
Contact:

[2.0.7] Crash when clicking mod dependency not in filtered mod list (ModInfoPane::showModRelease)

Post by MBGames »

When I view an installed mod in the in-game menu (/Mods/Manage/*) and click on a dependency, for example "Factory Planner" (v2.0.1) needs base>=2.0.7, I am redirected to the base-mod view.

If I, however, use the search function (I searched for "Factory Planner"), and I click on a dependency not in the filtered list, e.g. base>=2.07, the game crashes when looking for the base mod in /Mods/Explore, as it can't find it in the filtered /Mods/Manage list.
Attachments
crash_20241021-1544.log
(23.91 KiB) Downloaded 16 times
Rseding91
Factorio Staff
Factorio Staff
Posts: 16000
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: [2.0.7] Crash when clicking mod dependency not in filtered mod list

Post by Rseding91 »

Thanks for the report. This is fixed for the next release.
If you want to get ahold of me I'm almost always on Discord.
MBGames
Burner Inserter
Burner Inserter
Posts: 5
Joined: Mon Oct 21, 2024 2:05 pm
Contact:

Re: [2.0.7] Crash when clicking mod dependency not in filtered mod list

Post by MBGames »

Thank you for the fast reply and I can't wait to play the expansion :D
MBGames
Burner Inserter
Burner Inserter
Posts: 5
Joined: Mon Oct 21, 2024 2:05 pm
Contact:

Re: [2.0.7] Crash when clicking mod dependency not in filtered mod list (ModInfoPane::showModRelease)

Post by MBGames »

As a software developer, I'd be interested to know the reason why this crash occures. I suspect base-mod can't be found in the filtered list, therefore the game looks it up on the mod-page.
Since base-mod is not published there, the response from the server is not handled properly when no mod can be found. Am I correct with this assumption?
Rseding91
Factorio Staff
Factorio Staff
Posts: 16000
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: [2.0.7] Crash when clicking mod dependency not in filtered mod list (ModInfoPane::showModRelease)

Post by Rseding91 »

During the rework of the install-mods GUI for 2.0 into the explor-mods GUI some incorrect assumptions were made about fetching mod info from the server. Things which "might fail" were assumed to never fail and if they failed - such as this case - the game would crash instead of handle it gracefully.
If you want to get ahold of me I'm almost always on Discord.
MBGames
Burner Inserter
Burner Inserter
Posts: 5
Joined: Mon Oct 21, 2024 2:05 pm
Contact:

Re: [2.0.7] Crash when clicking mod dependency not in filtered mod list (ModInfoPane::showModRelease)

Post by MBGames »

FYI, after the fix the crash still occurs, but this time after clicking on it the second time.
Rseding91
Factorio Staff
Factorio Staff
Posts: 16000
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: [2.0.7] Crash when clicking mod dependency not in filtered mod list (ModInfoPane::showModRelease)

Post by Rseding91 »

MBGames wrote: Tue Oct 22, 2024 4:01 pm FYI, after the fix the crash still occurs, but this time after clicking on it the second time.
I missed one of the spots. It should be handled in 2.0.8 or 2.0.9, one of the upcoming releases.
If you want to get ahold of me I'm almost always on Discord.
MBGames
Burner Inserter
Burner Inserter
Posts: 5
Joined: Mon Oct 21, 2024 2:05 pm
Contact:

Re: [2.0.7] Crash when clicking mod dependency not in filtered mod list (ModInfoPane::showModRelease)

Post by MBGames »

Sorry missed that.
Attachments
factorio-current.log
(24.09 KiB) Downloaded 11 times
Post Reply

Return to “Resolved Problems and Bugs”