[Genhis][2.0.6] Failed Translation Request

[Cooldude2606]

TL;DR LuaPlayer.request_translation will fail if the locale string contains empty strings.

Reproduction
1) Setup the files for minimal reproduction, see below.
2) Run the first command, it will output "foo:bar:baz" and "translated" is true.
3) Run the second command, it will output "foo::baz" but "translated" is false.
4) Run the third command, it will output "foobaz" and "translated" is true.

The Issue
It is expected that an invalid locale string will display an error when printed, such as "Unknown key" and this would also cause a translation request to fail. However in the case described above the locale string is valid and is printed without error but the translation request fails. This is inconsistent behaviour because one is successful while the other fails. Additionally, it only fails when using a locale key, it will not fail during concatenation. If for some reason this locale string is not valid, then it is not documented that this would cause a failure and no error message is printed.

Files

Locale:

Code: Select all

[scenario]
string=__1__:__2__:__3__

Control:

Code: Select all

script.on_event(defines.events.on_string_translated, function(event)
    game.print(event.localised_string)
    game.print(serpent.line(event))
end)

Commands:

Code: Select all

/c game.player.request_translation{"scenario.string", "foo", "bar", "baz"}
/c game.player.request_translation{"scenario.string", "foo", "", "baz"}
/c game.player.request_translation{"", "foo", "", "baz"}

[Genhis]

Thanks for the report, this is fixed for the next release.