[Rseding91] [1.1.110] on_init errors not reported with --create flag

This subforum contains all the issues which we already resolved.
Gweneph
Inserter
Inserter
Posts: 45
Joined: Thu Nov 14, 2019 11:51 pm
Contact:

[Rseding91] [1.1.110] on_init errors not reported with --create flag

Post by Gweneph »

When a mod's on_init handler fails from creating a save file from the gui it gets reported and prevents the new save from being played.

When a save game is created via the --create command line flag, the error is reported via stdout. However, the save game file is still created and the error does not appear in the log:
logfile wrote: 1.741 Checksum for script __FactorioAccess__/control.lua: 1409838822
1.876 Goodbye
stdout wrote: 1.741 Checksum for script __FactorioAccess__/control.lua: 1409838822
Error: The mod Factorio Access Mod (0.12.3) caused a non-recoverable error.
Please report this error to the mod author.

Error while running event FactorioAccess::on_init()
__FactorioAccess__/control.lua:6217: oh No!
stack traceback:
[C]: in function 'error'
__FactorioAccess__/control.lua:6217: in function <__FactorioAccess__/control.lua:6212>
1.876 Goodbye
I would expect that the save file generation would fail, and the error to appear in the log.
Attachments
factorio-previous.log
log file missing the error
(2.58 KiB) Downloaded 18 times
Rseding91
Factorio Staff
Factorio Staff
Posts: 14336
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: [Rseding91] [1.1.110] on_init errors not reported with --create flag

Post by Rseding91 »

Thanks for the report, this appears to be fixed in 2.0 as part of the work done there.
If you want to get ahold of me I'm almost always on Discord.
Post Reply

Return to “Resolved Problems and Bugs”