Separate the 2 functions of "catalyst_amount" into 2 parameters

[Wiwiweb]

What?

Currently you can add a "catalyst_amount" parameter to ingredients or results of a recipe.
Added on an result, this has two functions:

• It stops the product from appearing in production stats.
• It prevents it from being affected by productivity.

I would like have 2 new parameters to individually control these two functions with 2 new booleans: "ignored_by_stats" and "ignored_by_productivity".

In addition, "catalyst_amount" acts on stats in strange ways when the amount products is variable (either via probability or with amount_min/amount_max).
For example if a recipe has 50% chance to output stone, and that product has catalyst_amount = 1 (has to be an int), then when the recipe outputs stone it works as expected (stone does not appear in stats) but when the recipe does not output stone then 1 stone appears in consumption stats. I'm guessing the catalyst amount is subtracted from the actual amount produced, which results in -1 production, which ends up as 1 consumption.

The "ignored_by_stats" boolean proposed would allow variable results to be properly ignored in stats.

Why?

In SE, we have a lot of recipes that output stone or sand as byproduct, which is usually something players want to get rid of. We currently mark those as catalyst because we want to encourage high productivity, and we don't want players to be punished for it by getting more waste. This makes sense thematically too since a more productive machine could get more usable ore and less waste.

But the byproducts end up not showing up in production stats even though it is produced. Sometimes it may even show in consumption stat because of the issue with variable products mentioned above.

Ideally, we would prevent productivity on this product, while still having it show in statistics.

Thanks!

[curiosity]

For example if a recipe has 50% chance to output stone, and that product has catalyst_amount = 1 (has to be an int), then when the recipe outputs stone it works as expected (stone does not appear in stats) but when the recipe does not output stone then 1 stone appears in consumption stats. I'm guessing the catalyst amount is subtracted from the actual amount produced, which results in -1 production, which ends up as 1 consumption.

This should be submitted as a bug report.

[spiral_power]

Cheers!

Here's my earlier post.
viewtopic.php?f=23&t=90157

[KiwiHawk]

Makes sense! The new parameter would only need to be added to products though, not ingredients.

[KiwiHawk]

Revisiting October 2023

I've once again come across the need for this in Angel's! Any bug reports we get about the production graphs being wrong we just have to call a known issue, outside our control.

[raiguard]

This has been implemented for 2.0 as ignored_by_productivity and ignored_by_stats. Additionally, the auto-detection of catalysts has been removed.

[KiwiHawk]

Has catalyst_amount been removed? If not, is setting catalyst_amount equivalent to setting both of the new properties? What happens if both catalyst_amount and one of the new properties are set but to different numbers?

[Bilka]

catalyst_amount is removed in 2.0.

[Wiwiweb]

Hell yeah

[Mernom]

The whole vanilla case for the catalyst system was to allow the K process to work properly with prod. If the new params are bools, doesn't that break that intent?
Unless they are meant to be used in duplicate results entries? Aka

Code: Select all

local res = {
  { name = "thing", amount = 5, ignore = true },
  { name = "thing", amount = 1, ignore = false }
  ...
}

[curiosity]

The whole vanilla case for the catalyst system was to allow the K process to work properly with prod. If the new params are bools, doesn't that break that intent?
Unless they are meant to be used in duplicate results entries? Aka

Code: Select all

local res = {
  { name = "thing", amount = 5, ignore = true },
  { name = "thing", amount = 1, ignore = false }
  ...
}

No one said they are booleans. That doesn't even make any sense to assume.

[Wiwiweb]

It's not a crazy assumption; in the OP I suggested ignored_by_productivity and ignored_by_stats as booleans, and the implementation uses those exact names.
Of course since catalyst_amount is also going away, then it would make sense that those 2 new parameters are actually ints or floats, but it's good to ask to get clarification.

[curiosity]

It's not a crazy assumption; in the OP I suggested ignored_by_productivity and ignored_by_stats as booleans, and the implementation uses those exact names.

Oh, sorry, my bad. Last time I've read that post was a long time ago.

[Bilka]

Don't worry, the new properties are numbers.

[spiral_power]

Thank you for your efforts.