[1.1.53] Game to Continue not updated by Save

[bnvy]

I believe there is an inconsistency between how you remember the game "last played", for use on the Continue button, and what game should be used to pre-select a file for the Save function.

Here's a case that seems wrong to me. My backup strategy is to create another save each day I play, preserving what I had done the previous day. For example, say I "Continue game-23" from yesterday, and immediately "Save game-24 " for today.

If I play for a while and then save again, game-23 is preselected for me, but I think I've been playing on game-24, and if I don't notice, I lose my backup from yesterday.

Then when I come back tomorrow, you suggest I Continue game-23 (and it did actually save there, which is sort of correct), but I'm thinking I was playing 24. In the simple case I'll probably sort this out, but if I digress to play around in a test world for a bit, then come back to resume my "latest" game, I may not notice that it's missing yesterday's progress.

My workaround is to completely exit the game after first saving under the new name. Re-launching the game, it then works as expected, using game-24 for both Continue and Save.

Essentially, in the case I describe it seems to function as "Save A Copy" but keep playing in the current one, while I'm expecting it to behave like "Save As", creating a new save and then continuing in that one. My guess is that the fix, assuming you agree one is needed, would involve updating your memory of the last file used for saving, but there may be some reason you prefer not to do that.

This is not new behavior, and dates to sometime around the UI overhaul for 1.0, when Play (sadly) changed to Continue. I should also note the possibility that this is Mac-specific, though I doubt it. I'm currently on the latest release (1.1.53), and single player only.

I apologize for not raising this long ago, but it's fairly obscure, things mostly work fine, and my workaround is simple enough (as long as I cache sprites and prototypes) and has become routine. Thanks for your consideration, and exemplary work as always.

[Xorimuth]

This same bug has been bothering me for quite some time (on macOS):

1. Load 'game1'
2. Save game as name 'game2'
3. Play a bit more
4. Save game again, the suggested name is 'game1' instead of the expected 'game2'

This bit is definitely a bug. I think that the Continue problems mentioned are just a symptom of saving under the wrong name, and not directly a bug in itself (but my understanding may be wrong).

This bug only occurs when non-blocking saves is enabled.

Hopefully you still want to fix it despite the 'experimental' nature of the feature . The issue seems similar to viewtopic.php?f=11&t=92804, which also only occurred with non-blocking saves.

(Log wouldn't attach as a separate file so here it is, with repetitive graphics-loading lines manually removed)

Code: Select all

   0.000 2022-04-07 02:02:44; Factorio 1.1.57 (build 59622, mac, steam)
   0.000 Operating system: macOS 10.16.0
   0.000 Program arguments: "/Users/tomburrows/Library/Application Support/Steam/steamapps/common/Factorio/factorio.app/Contents/MacOS/factorio" 
   0.000 Read data path: /Users/tomburrows/Library/Application Support/Steam/steamapps/common/Factorio/factorio.app/Contents/data
   0.000 Write data path: /Users/tomburrows/Library/Application Support/factorio [19438/572204MB]
   0.000 Binaries path: /Users/tomburrows/Library/Application Support/Steam/steamapps/common/Factorio/factorio.app/Contents
   0.092 System info: [CPU: Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz, 16 cores, RAM: 16384 MB]
   0.092 Display options: [FullScreen: 1] [VSync: 1] [UIScale: custom (200.0%)] [Native DPI: 1] [Screen: 255] [Special: lmW] [Lang: en]
   0.195 Available displays: 1
   0.195  [0]: Color LCD - {[0,0], 1792x1120, SDL_PIXELFORMAT_ARGB8888, 60Hz, 0x7bd7eef9(0x01)}
   2.495 Initialised OpenGL:[0] AMD Radeon Pro 5500M OpenGL Engine; driver: 4.1 ATI-4.8.15
   2.495   [Size] Window: 1792x1120, Backbuffer: 3584x2240
   2.495   [Extensions] s3tc:yes; KHR_debug:NO; ARB_clear_texture:NO, ARB_copy_image:NO
   2.495   [Version] 4.1
   2.495 Graphics settings preset: very-high
   2.495   Dedicated video memory size 4080 MB (detected from AMD Radeon Pro 5500M Compute Engine; VendorID: 0x1021e00)
   2.654 Graphics options: [Graphics quality: high] [Video memory usage: medium] [DXT: high-quality] [Color: 32bit]
   2.654                   [Max threads (load/render): 32/16] [Max texture size: 4096] [Tex.Stream.: 0] [Rotation quality: normal] [Other: STDCWT] [B:0,C:0,S:100]
   2.776 [Audio] Backend:default; Depth:16, Channel:2, Frequency:44100; MixerQuality:linear
   3.451 Info ModManager.cpp:261: Found duplicate mod VacuumBelts, using folder version (0.6.0).
   3.459 Loading mod core 0.0.0 (data.lua)
   3.530 Loading mod base 1.1.57 (data.lua)
   3.809 Loading mod base 1.1.57 (data-updates.lua)
   3.908 Checksum for core: 1636702648
   3.908 Checksum of base: 1844968960
   4.115 Prototype list checksum: 3034860339
   4.180 Loading sounds...
   4.616 Info PlayerData.cpp:73: Local player-data.json unavailable
   4.616 Info PlayerData.cpp:76: Cloud player-data.json available, timestamp 1649293353
   4.773 Initial atlas bitmap size is 4096
   5.479 Atlases loaded from disk cache.
   5.579 Texture processor created (2048). GPU accelerated compression Supported: yes, Enabled: yes/yes. Test passed. YCoCgDXT PSNR: 35.83, BC3 PSNR: 33.82
   6.216 Parallel Sprite Loader initialized (threads: 13)
  12.801 Sprites loaded
  13.362 Custom mipmaps uploaded.
  13.526 Factorio initialised
  13.530 Steam Storage Quota: 3031/4768
  15.230 Loading map /Users/tomburrows/Library/Application Support/factorio/saves/newgame1.zip: 1289059 bytes.
  15.253 Loading level.dat: 1406648 bytes.
  15.257 Info Scenario.cpp:199: Map version 1.1.57-1
  15.293 Loading blueprint storage: Local timestamp 1649293313, Cloud timestamp 1649293311
  15.308 Loading script.dat: 1182 bytes.
  15.312 Checksum for script /Users/tomburrows/Library/Application Support/factorio/temp/currently-playing/control.lua: 3795083680
  21.838 Info AppManagerStates.cpp:1845: Saving game as /Users/tomburrows/Library/Application Support/factorio/saves/newgame2 (non-blocking)
  21.934 Info AsyncScenarioSaver.cpp:156: Saving process PID: 80157
  22.041 Info ChildProcessAgent.cpp:60: Child 80157 exited with return value 0
  22.043 Uploaded files to cloud
  22.043 Info AppManagerStates.cpp:1846: Saving finished
  36.572 Info AppManagerStates.cpp:1845: Saving game as /Users/tomburrows/Library/Application Support/factorio/saves/newgame1 (non-blocking)
  36.664 Info AsyncScenarioSaver.cpp:156: Saving process PID: 80165
  36.775 Info ChildProcessAgent.cpp:60: Child 80165 exited with return value 0
  36.775 Uploaded files to cloud
  36.775 Info AppManagerStates.cpp:1846: Saving finished
  40.721 Quitting: user-quit.
  41.415 Steam API shutdown.
  41.423 Goodbye

[Rseding91]

Thanks for the report. It's now fixed for the next release.