[Tobias] [1.1.37] Undo of deconstruction in editor mode should instant revive (if enabled)

This subforum contains all the issues which we already resolved.
User avatar
NotRexButCaesar
Smart Inserter
Smart Inserter
Posts: 1133
Joined: Sun Feb 16, 2020 12:47 am
Contact:

[Tobias] [1.1.37] Undo of deconstruction in editor mode should instant revive (if enabled)

Post by NotRexButCaesar »

I am aware of 84210! Loewchen, please read before you move to duplicates.

When removing an entity in the editor, the undo command yields a ghost.

This was reported as a bug in 0.18.21, but Rseding decided not to fix it because "undo isn't officially supported in the map editor;" however, in 1.1.21, Kovarex fixed 96015, despite the link to 65683, another 'won't fix, it is not supported' from Rseding. Sic, Kovarex must have decided to support undo in the editor by 1.1.21: for this reason I believe the bug should be at least reconsidered.
—Crevez, chiens, si vous n'étes pas contents!
User avatar
Klonan
Factorio Staff
Factorio Staff
Posts: 5304
Joined: Sun Jan 11, 2015 2:09 pm
Contact:

Re: [1.1.37] Undo of deconstruction in editor mode produces ghost.

Post by Klonan »

And what do you expect? That it produces a fully built entity?
Loewchen
Global Moderator
Global Moderator
Posts: 9548
Joined: Wed Jan 07, 2015 5:53 pm
Contact:

Re: [1.1.37] Undo of deconstruction in editor mode produces ghost.

Post by Loewchen »

That does change nothing about it being a duplicate, if you think the assessment of an issue has changed post in the original report, do not intentionally create duplicates.
User avatar
NotRexButCaesar
Smart Inserter
Smart Inserter
Posts: 1133
Joined: Sun Feb 16, 2020 12:47 am
Contact:

Re: [1.1.37] Undo of deconstruction in editor mode produces ghost.

Post by NotRexButCaesar »

Klonan wrote: Sat Aug 14, 2021 6:40 pm And what do you expect? That it produces a fully built entity?
I would expect it to produce a full entity, similar to how undoing construction completely removes the entities rather than adds a deconstruction order to them.
Loewchen wrote: Sat Aug 14, 2021 6:41 pm That does change nothing about it being a duplicate, if you think the assessment of an issue has changed post in the original report, do not intentionally create duplicates.
What is the correct action to take?
Should we ask on the original post to have it moved?
—Crevez, chiens, si vous n'étes pas contents!
User avatar
Klonan
Factorio Staff
Factorio Staff
Posts: 5304
Joined: Sun Jan 11, 2015 2:09 pm
Contact:

Re: [1.1.37] Undo of deconstruction in editor mode produces ghost.

Post by Klonan »

NotRexButCaesar wrote: Sat Aug 14, 2021 7:20 pm What is the correct action to take?
I'll ask kovarex to decide
Loewchen
Global Moderator
Global Moderator
Posts: 9548
Joined: Wed Jan 07, 2015 5:53 pm
Contact:

Re: [1.1.37] Undo of deconstruction in editor mode produces ghost.

Post by Loewchen »

NotRexButCaesar wrote: Sat Aug 14, 2021 7:20 pm Should we ask on the original post to have it moved?
Yes.
kovarex
Factorio Staff
Factorio Staff
Posts: 8207
Joined: Wed Feb 06, 2013 12:00 am
Contact:

Re: [kovarex] [1.1.37] Undo of deconstruction in editor mode should instant revive (if enabled)

Post by kovarex »

Probably yes. (now I un-assign myself from this)
Tobias1595
Factorio Staff
Factorio Staff
Posts: 40
Joined: Sat Sep 29, 2018 5:28 pm
Contact:

Re: [Tobias] [1.1.37] Undo of deconstruction in editor mode should instant revive (if enabled)

Post by Tobias1595 »

Thanks for the report. The issue has been fixed for 1.1.40.
User avatar
NotRexButCaesar
Smart Inserter
Smart Inserter
Posts: 1133
Joined: Sun Feb 16, 2020 12:47 am
Contact:

Re: [Tobias] [1.1.37] Undo of deconstruction in editor mode should instant revive (if enabled)

Post by NotRexButCaesar »

Tobias1595 wrote: Wed Sep 08, 2021 2:26 pm Thanks for the report. The issue has been fixed for 1.1.40.
Thank you! This was very annoying for resetting combinator memory in editor mode.

It looks like you might have forgotten to move this from Assigned to Fixed for the next release.
—Crevez, chiens, si vous n'étes pas contents!
Post Reply

Return to “Resolved Problems and Bugs”