[posila] [1.1.33] Game freezes when BP book is deleted while being moved

[Drogiwan Cannobi]

Hi,
I found an issue with BP books: I have BP books that get taken out of trains into chests, looped around and put back into trains. I wanted to delete and replace one of them and had some unfortunate timing: The book was in chest A when I opened it (and maybe clicked the "delete" button, I'm not 100% sure) and got moved to chest B before I confirmed the delete. This seems to cause a complete freeze. I had to force quit.
I've been able to reproduce it, record a video and make a save file right before it happens. If you want to reproduce it: The book gets moved when the train leaves, so you want to edit it when it's in the station and then confirm the delete after it leaves.
The log doesn't say anything at all, the last entry is "saving finished".

Damn, I didn't think the game freezing was even possible in factorio!

[bormand]

And another simple reproduction:

- place an unpowered inserter
- put a blueprint into the hand slot of that inserter
- destroy blueprint

Deconstruction and upgrade planners freeze game too.

P.S. It may be a slightly different issue, since in the original issue book was already moved. And here it was destroyed inside the inserter.

[posila]

Thanks for the reports.

Both of these issues are fixed for 1.1.36

Note: Items in general don't have backreference to an entity that contains them (blueprint books do have it, blueprints/decon and upgrade planners don't), and it is not possible to delete an item when it was moved to different entity - it's a flaw that I consider beyond scope of this bug report, and very much minor issue.