[1.1.32] Lights render resolution option does absolutely nothing

This subforum contains all the issues which we already resolved.
Hornwitser
Fast Inserter
Fast Inserter
Posts: 215
Joined: Fri Oct 05, 2018 4:34 pm
Contact:

[1.1.32] Lights render resolution option does absolutely nothing

Post by Hornwitser »

I was curious how this graphics option updated on the fly, and tried to make the rendering resolution of lights increase. But no matter how much I switched between 0.25 and 1 at night I couldn't see any difference at all, even after restarting the game.

So I started digging and found DrawEngine.cpp:611 and EngineFramebuffers.cpp:144 and now I'm convinced this option does absolutely nothing.
posila
Former Staff
Former Staff
Posts: 5448
Joined: Thu Jun 11, 2015 1:35 pm
Contact:

Re: [1.1.32] Lights render resolution option does absolutely nothing

Post by posila »

You are correct. In 1.1 light rendering was changed to separate light maps affecting large areas (like lamps) and detail lights that are usually just tiny LEDs. Area lights are very GPU intensive when rendered in full resolution, while having no (or barely any) extra visual fidelity from being rendered in higher resolution, while detail lights suffer from flickering during movement when rendered in lower resolution, especially when zoomed out. So, point is ... the option is no longer required (and is not used), but there is currently nothing to put in its place, and just removing it from the GUI would break the nice alignment of the two halves of the GUI, so I have left it there :)
User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 5211
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: [1.1.32] Lights render resolution option does absolutely nothing

Post by eradicator »

posila wrote: Sat Apr 24, 2021 5:26 pm removing it from the GUI would break the nice alignment of the two halves of the GUI, so I have left it there :)
ymmd :D
Author of: Belt Planner, Hand Crank Generator, Screenshot Maker, /sudo and more.
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.
posila
Former Staff
Former Staff
Posts: 5448
Joined: Thu Jun 11, 2015 1:35 pm
Contact:

Re: [1.1.32] Lights render resolution option does absolutely nothing

Post by posila »

Ok, I decided to not be lazy piece of ... human being today and removed the option for the next release.
Thanks for the report.
Post Reply

Return to “Resolved Problems and Bugs”