Remove depth box if no banner picture

[ssilk]

See viewtopic.php?f=189&t=93019

I changed my opinion and think it would make sense to have no empty depth box, if there is no banner picture for a mod.

E3188414-ADC8-414E-8E46-36E766D235B7.png (216.16 KiB) Viewed 2194 times

[Deadlock989]

Yeah, dead grey space without a border is tight.

So much better than dead grey space with a border.

PS. I don't know why you insist on calling it a "banner picture". The mod portal and modding documentation calls it a thumbnail. The file that creates it is named thumbnail.png. Banners are something else.

[Klonan]

probably better just to use the 'MIssing thumbnail' as in the base game

factorio-run_2021-01-09_12-36-08.png (3.54 KiB) Viewed 2169 times

[Deadlock989]

Better how? Why would it be better to have pages full of icons that look like error messages?

The most downloaded mod of all time is RSO, with 1.375 million downloads. It's 8% ahead of the mod with the second highest.

It doesn't have a thumbnail. Clearly not having thumbnails is a serious impediment to ... nothing.

At any rate, at least I've found a new thumbnail.

[ssilk]

probably better just to use the 'MIssing thumbnail' as in the base game

I like that.

[Xorimuth]

probably better just to use the 'MIssing thumbnail' as in the base game

I like that.

I don't. I think that it is fine how it is.

[Deadlock989]

Thumbnails are an optional part of the mod structure specification. They are not "missing" because they do not have to exist, so the in-game display of "Missing thumbnail" is wrong and misleading: the mod has no fault whatsoever if it does not supply a thumbnail. If you want an analogy, an OS file browser would never show "Missing thumbnail" in non-localised rasterised text if the files didn't have a preview thumbnail available; the thumbnail is not missing in exactly the same way that an aardvark on toast is not missing. "No thumbnail" would be less inaccurate but still alarmist and still non-localised. Some incredibly dim and unnoticeable placeholder image like the generic "picture" icon used would be less of a problem but if you're climbing down that far then an empty frame is pretty much the same thing.

I guess I could start a thread about the horror of using non-localisable rasterised text messages in icons that but it seems like a waste of everyone's time to be so pedantic.

[ssilk]

Perhaps we could agree on this: it’s currently inconsistent for the web and in-game-browser. Please change that.