[1.1.5] One train can reserve multiple spots at a stop

[robobenklein]

If you make a very small loop with two stations and enforce a 1 train limit on both, with only one train on the tracks going between them with no stopping conditions it will come to a halt at one of the stops.

I would expect the train to only be able to hold one reservation at a stop at any given time, but if we increase one of these two stops to allow a 2 train limit somehow that limit of 2 applies to only one train.

Video showing this behavior:

2020-12-10 01-44-54.mp4

Video of train and loop where one train reserves two spots in one stop

(29.73 MiB) Downloaded 78 times

[boskid]

Everything is exactly as designed. If train has path expanded due to waypoints it has to keep extra reservation for every waypoint to avoid some cases where train would get stuck after repathing. You can read more about this in viewtopic.php?p=475917#p475917:

I found out what was issue here. Waypoints force special train behavior. Train may show it is going to stacker train stop but its braking point is already ahead and so train internally no longer keeps stacker train stop reserved. Other trains reserved all stacker train stops slots. When train was forced to repath on signal (because braking point was unable to reserve rail signal), it repathed from its current position, failed to reserve stacker train stop and entered nopath (or pathed to adjacent lane). To fix this, i would have to keep reservations for waypoint train stops until they are officially passed by train.

In current implementation this has the consequence of trains count sometimes counting the same train multiple times.