[boskid][1.1.3] Crash right after loading seablock save (TransportLineManager::update)

[snooozer]

Use modded seablock, so not sure if mods need to e updated, but this one seems to be a factorio bug:

Code: Select all

Raw stacktrace: 0xcfb877, 0xef8bcd, 0xd53505, 0xd53b91, 0xd53c49, 0x3f040, 0xeaf304, 0x12afa69, 0x12b0057, 0x12b0450, 0x12b07db, 0x12deb94, 0x12dee85, 0xd13a11, 0x1fb41e0, 0x76db, 0
  77.989 Warning Logger.cpp:526: Symbols.size() == 26, usedSize == 16
#0  0x0000000000ef8bcd in std::__uniq_ptr_impl<LoggerFileWriteStream, std::default_delete<LoggerFileWriteStream> >::_M_ptr() const at /home/build/gcc-9.2/include/c++/9.2.0/bits/unique_ptr.h:154
#1  0x0000000000d53505 in std::unique_ptr<LoggerFileWriteStream, std::default_delete<LoggerFileWriteStream> >::get() const at /home/build/gcc-9.2/include/c++/9.2.0/bits/unique_ptr.h:353
#2  0x0000000000d53b91 in std::unique_ptr<LoggerFileWriteStream, std::default_delete<LoggerFileWriteStream> >::operator->() const at /home/build/gcc-9.2/include/c++/9.2.0/bits/unique_ptr.h:347
#3  0x0000000000d53c49 in Logger::flush() at /tmp/factorio-build-Z4Zngo/src/Util/Logger.cpp:566
#4  0x000000000003f040 in Logger::logStacktrace(StackTraceInfo*) at /tmp/factorio-build-Z4Zngo/src/Util/Logger.cpp:552
#5  0x0000000000eaf304 in GlobalContext::getMap() at /tmp/factorio-build-Z4Zngo/src/GlobalContext.cpp:2008
#6  0x00000000012afa69 in CrashHandler::writeStackTrace(CrashHandler::CrashReason) at /tmp/factorio-build-Z4Zngo/src/Util/CrashHandler.cpp:188
#7  0x00000000012b0057 in CrashHandler::commonSignalHandler(int) at /tmp/factorio-build-Z4Zngo/src/Util/CrashHandler.cpp:623
#8  0x00000000012b0450 in CrashHandler::SignalHandler(int) at /tmp/factorio-build-Z4Zngo/src/Util/CrashHandler.cpp:638
#9  0x00000000012b07db in ?? at ??:0
#10 0x00000000012deb94 in TransportLineManager::update(unsigned int, ThreadPool&) at /tmp/factorio-build-Z4Zngo/src/Entity/TransportLineManager.cpp:79
#11 0x00000000012dee85 in Map::updateEntities() at /tmp/factorio-build-Z4Zngo/src/Map/Map.cpp:1509
#12 0x0000000000d13a11 in Map::update() at /tmp/factorio-build-Z4Zngo/src/Map/Map.cpp:1471
#13 0x0000000001fb41e0 in Game::update() at /tmp/factorio-build-Z4Zngo/src/Game.cpp:208
#14 0x00000000000076db in Scenario::update() at /tmp/factorio-build-Z4Zngo/src/Scenario/Scenario.cpp:1254

Full Log:

factorio-crash.log

(16.36 KiB) Downloaded 161 times

Thanks for the great updates and let me know if you need the save-game

[boskid]

This crash happened in the place where i would completly not expect it to crash, but maybe i am assuming something wrong. If you can reproduce this crash with a save file and some steps i would really like to see that. Just a log file is not enough.

[snooozer]

I have done more experimenting. I can reproduce the issue without any mods enabled. So just launching native factorio without the need to sync the mods enables to reproduce the issue.

Save-Game:
https://www.dropbox.com/s/0pe98t3f53lp5 ... ents_6.zip

Hopes that helps to reproduce.

*Edit*
Steps to reproduce:
- Open vanilla factorio
- Load game without the need to sync with mods (no mods enabled)
- Wait for the game to crash (no movements or player input needed)

[boskid]

I see, it really crashes.

Quickly checking, issue is around transport line between yellow arrows (from {629.5, -321.5} to {617.5, -322.5}) which spans basic belts and basic underground belts from bob's logistics:

92374-line.png (697.54 KiB) Viewed 2946 times

When this mod is disabled, those belts and undergrounds are removed from the save and most likely something goes wrong due to belt weaving with yellow undergrounds. I will have to check that.

[boskid]

Thanks for the report. Issue is now fixed for 1.1.4.

[snooozer]

Thanks for the investigation and the quick fix!