[1.0] Next day didn`t come - solar are not working

[PMGPMG]

What did you do?
I was building solar megabase. I build a lot of solars and for last couple hours I left computer running (to let robots build what they should). After I came to computer I saved and spotted that my solars didnt kick in back.

No power on solars

2020-09-08_21h06_32.png (1.45 MiB) Viewed 6673 times

Best screenshot with day - night cycle.

2020-09-08_21h06_27.png (1.62 MiB) Viewed 6673 times

As you can see even on 1h diagram "longer" day is visible.

2020-09-08_21h06_44.png (1.47 MiB) Viewed 6673 times

What happened?
next round of "solars waking up and charge my accumulators" didnt happended.

What did you expect to happen instead? It might be obvious to you, but do it anyway!
Next round of "solars starts from almost zero and gradually charge my accumulators" happened.

I left game for some time and it just discharged my accumlators and made mess in my base (I had separate grids for bots - it mixed them).

I tried to use console commands from https://www.reddit.com/r/factorio/comme ... me_of_day/
but only "light" changing part was happening - it didn`t influence charging.


Files:

https://pastebin.com/J4rijq7r
config.ini

https://pastebin.com/Wgpbg5n6
current.log

https://pastebin.com/pXjQAxLu
previous.log

https://drive.google.com/file/d/1aFt9Np ... sp=sharing
savefile

[MassiveDynamic]

Are you absolutely positive that the solar array is connected to the power grid that you are checking?

[Squelch]

https://drive.google.com/file/d/1aFt9Np ... sp=sharing
savefile

The save at that location does not seem to be the correct one with reference to your pictures. No solar, and what seems to be some experiments with Trains and combinator circuits.

[TruePikachu]

Just to add here (I've already commented on the Reddit post), I've gone through a brief disassembly of the `ElectricNetwork::solarProduction` function, since a lot of people on Reddit are suspecting integer overflow. I don't see evidence of this within the function; while the number of solar panels of each prototype on a subnetwork is indeed stored as `int32_t`, it is converted to a floating point number before being multiplied by the amount of power the prototype produces, and I don't see any conversions back down to an integer within the mentioned function.

[PMGPMG]

https://drive.google.com/file/d/1aFt9Np ... sp=sharing
savefile

The save at that location does not seem to be the correct one with reference to your pictures. No solar, and what seems to be some experiments with Trains and combinator circuits.

I have no idea what you are talking about, so I will post next set of screenshots to provide more context.

[PMGPMG]

2020-09-12_20h47_25.png (1.54 MiB) Viewed 6514 times

2020-09-12_20h47_44.png (798.9 KiB) Viewed 6514 times

2020-09-12_20h47_52.png (920.77 KiB) Viewed 6514 times

2020-09-12_20h48_10.png (835.71 KiB) Viewed 6514 times

2020-09-12_20h48_43.png (937.39 KiB) Viewed 6514 times

2020-09-12_20h48_54.png (962.87 KiB) Viewed 6514 times

2020-09-12_20h49_31.png (1.42 MiB) Viewed 6514 times

2020-09-12_20h49_47.png (865.97 KiB) Viewed 6514 times

2020-09-12_20h49_55.png (833.36 KiB) Viewed 6514 times

2020-09-12_21h13_26.png (1.03 MiB) Viewed 6514 times

[PMGPMG]

2020-09-12_21h15_28.png (1.11 MiB) Viewed 6512 times

Last screenshot before whole situation is going down, whole game have 0,1 FPS etc.

Whole base had nickname "one screen of solars". That was my goal - build one screen (with maximum zoom out on map) of solars, and then build some passive thing to use this power (thats why becaons on north of solar field)

For context - here is save game around 30 minutes before crash

https://drive.google.com/file/d/1_8myR2 ... sp=sharing

sadly this 30 minutes is on my computer some more than hours, because I have max 11 FPS / UPS .

FOR DEVELOPER/TESTER THAT WILL REVIEW THIS TICKET:
When I am not a Factorio bug reported I am Software Tester. If you need some more context etc, please ask here or on piotr.pmg.gackowski<on>gmail.com

[PMGPMG]

Are you absolutely positive that the solar array is connected to the power grid that you are checking?

Yes. My whole base is "one power network" (that is whole point of this base), you can check on screenshots.

2020-09-12_21h38_51.png (248.75 KiB) Viewed 6508 times

2020-09-12_21h39_14.png (454.72 KiB) Viewed 6508 times

2020-09-12_21h39_31.png (1.32 MiB) Viewed 6508 times

2020-09-12_21h39_36.png (1.36 MiB) Viewed 6508 times

Only two small grids are not connected:

2020-09-12_21h38_32.png (616.71 KiB) Viewed 6508 times

[boskid]

Congratulations, you have more than 8388608 solar panels in a single electric network. This overflows variable that tracks total number of solar panels in a given electric network and game thinks you have -8386651.000 solar panels so they do not produce any electricity. To workaround this you may isolate huge chunk of solar panels and connect both electric networks using PowerSwitch - that way they will be connected but solar panels counter will not be shared.

[Squelch]

https://drive.google.com/file/d/1aFt9Np ... sp=sharing
savefile

The save at that location does not seem to be the correct one with reference to your pictures. No solar, and what seems to be some experiments with Trains and combinator circuits.

I have no idea what you are talking about, so I will post next set of screenshots to provide more context.

The file that you linked to in the first post - aasolar137v10nocliffa.zip - did not appear to be the save that you were talking about. I downloaded it to see if I could replicate your problem, but it did not have any solar panels in the save. I see the second file is - aasolar136v10nocliffa.zip - and this problem now seems to have been identified, so I will not proceed.

[valneq]

Congratulations, you have more than 8388608 solar panels in a single electric network. This overflows variable that tracks total number of solar panels in a given electric network and game thinks you have -8386651.000 solar panels so they do not produce any electricity. To workaround this you may isolate huge chunk of solar panels and connect both electric networks using PowerSwitch - that way they will be connected but solar panels counter will not be shared.

Why is the counter not an unsigned data type? Negative numbers of entities kind of don't make any sense anyway.

[boskid]

Why is the counter not an unsigned data type? Negative numbers of entities kind of don't make any sense anyway.

I think it is super unlikely to have an unsigned-floating point or unsigned-fixed point type. Solar panel counter is reusing fixed point based on int32_t with a resolution of 1/256 and so the limiting value (solar panel in range of multiple electric networks will be included as fraction in all of them so the need for fractions).

[starlinvf]

Congratulations, you have more than 8388608 solar panels in a single electric network. This overflows variable that tracks total number of solar panels in a given electric network and game thinks you have -8386651.000 solar panels so they do not produce any electricity. To workaround this you may isolate huge chunk of solar panels and connect both electric networks using PowerSwitch - that way they will be connected but solar panels counter will not be shared.

Why is the counter not an unsigned data type? Negative numbers of entities kind of don't make any sense anyway.

Its so you can produce negative energy; which is needed to power the warp drive to get home. WUBE seems to have tipped their hand on a new update.

[Theikkru]

It blows my mind that this bug exists because someone unintentionally brute-forced an int limitation with a single-count in-game item (as opposed to some sort of polynomially or exponentially scaled number). I think everyone involved deserves a round of congratulations. This is peak Factorio.

[boskid]

It blows my mind that this bug exists because someone unintentionally brute-forced an int limitation with a single-count in-game item (as opposed to some sort of polynomially or exponentially scaled number). I think everyone involved deserves a round of congratulations. This is peak Factorio.

per electric network solarCounts is not save-loaded so it has to have exact value, always. Using some exponential scaled number it could happen that with enough solar panels there would be rounding error which would result in a desync of joining player, and in larger amount of solar panels it could have rounding error large enough that trying to add 1 would always round down not increasing power production from solar panels. Real solution here would be to change this particular counter to be based on int64_t. I am not doing that change.

[boskid]

In 1.1.9 this limit will no longer apply.

[orzelek]

In 1.1.9 this limit will no longer apply.

So did you actually do the change to 64 bit type?

[Kyralessa]

In 1.1.9 this limit will no longer apply.

So did you actually do the change to 64 bit type?

Yeah, hopefully it's not just a 32-bit number now, because you know somebody somewhere is going to build over a billion solar panels and hit that limit too.

[starlinvf]

In 1.1.9 this limit will no longer apply.

So did you actually do the change to 64 bit type?

Yeah, hopefully it's not just a 32-bit number now, because you know somebody somewhere is going to build over a billion solar panels and hit that limit too.

I have a feeling someone is already planning out a factory to specifically test this now.

[NotRexButCaesar]

I have a feeling someone is already planning out a factory to specifically test this now.

There was conversation about it on the discord server