[0.18.47] Crash with invalid iconspecification

[lyvgbfh]

An iconspecification for item_prototype.icons that has icon_mipmaps and icon_size, but no filename results in a crash when either opening the craft menu or trying to craft the item, despite the game successfully loading. This may also require pictures to be set on the prototype.

Attached are a log, dump, save, and a screenshot of an example prototype that can reproduce the issue.

Error ImageDrawOrder.cpp:63: Invalid sprite reference. Sprite: <EMPTY> {x = 0, y = 0, w = 0, h = 0}, 0x000002402326b638, owner: ee-super-inserter:item

[Rseding91]

Thanks for the report. I wasn't able to reproduce the game letting me load without 'icon' set but I was able to reproduce it loading with icons = {} and it reproduced the same crash you're getting. So, probably something erased the mipmap values you set before it finished the data stage?

Anyway, if you can get me a mod that reproduces the crash I can verify it's fixed. Otherwise it looks like the fix I found will address it.