[kovarex] [0.17.76] Trainfuel is not reliably applied from blueprint

[Calibretto22]

Game: 0.17.76 Vanilla

Setup:
- a blueprint with rails and a train that has fuel
- place blueprint repeatedly
- bots build rails and train
- moduleslots for fuel are applied

Bug:
- moduleslots for fuel are not reliably applied

Clarifiacations:
- mostly happens on trains that are rotated or diagonally
- error seems to happen more often on games that have high ups (60+) and less often in my megabase (~45 UPS)

Blueprintexample:

0eNrtWctu2zgU/ZVAqxnAEXjJy1e+YRZFgVkVRqDIjCOMLBmSnE4Q+N+HlORHUha97BhBC3jjQKJ4dHh07oPMa/ZQ79y2q5ohu3vNqrJt+uzuy2vWV+umqMO94WXrsrusGtwmW2RNsQlXXVHV2X6RVc3K/ZvdwX65yFwzVEPlpvnjxct9s9s8uM4/cJxZt2W7aYfq2Xm0bdv7KW0T3uNhbgXPrVXMCi0X2Yu/Aca/pO0qD1dMD7I8jJVt3XZh1oS9Hn8fxt8iPIPWMGE5SP8HUAnFBUNltAyc/Ur6MLfZlbUrutvHnfMrFfv94hve/Mi7H/ya10/D7bj0CHV1xnhVda6cRnkEVdBRkY6KdFROR5V0VEZHVTQ/cPkTfmC5RcvAKmDGgGESwXormPDcOgwLBNAKDfNDRkqBSmmrxvGHMG78XKaNFMZYVFII7k3E5YWtpcnCckMX1tBREwxr6agJhgVGcwGYXywrAND1SAg1oGcbnhBrQE83kOA0oOcbSLAanBLOY72rVrdfi7V/NgIKJFfEXqHozFPsTI9oSHEFPaQhxRWWqLPMp9Q5Auuc+dwJU8i809qAYkai1IaBz7sGtZKKxz4APwV+ueue3ep7Czq+9u16RAwzISZnVHyLCjFUTlOJ5Rz5mU7cO09YNi7/G52ipuTkKGVx+lFQTAXlBE3ILQGPg0aZqlRQRmBKjkiMg0aZGpolfNxYwGCBCVvn5lhsaI6wiezNjxURjIqpopgxngISMRWBJ7kUmihmlKdIxCTkB4E0MwDLz73Ac993JplBkIPuUAQI6UGoVFBCehDkoDtUQUJ6ECYRlJAdBLECgsyZsQYPjQbPx6aD+uWQHHJzs0HIQQiJmITvhuSQm9s5wmdDkYhJCDkk17S5myUEAkrSToSznE1VfQT2zRByG49i8ZH7EVSJkhAyMJLDeN6LEDIwmkRMQkVDcpWct2KEiiZZIialGZG0MzCO+fG0IiDD4ZLgsd/k5EOSM818mkBpy6RIBSXkREnONfNpCqXVlTIVlJAVJb1/NlHQKFNNsqwIu5+znTioXHItMFokhUDNQWthFDfCaJTzhvLj0qU0tO1naGzDct7tPnU47O7LJ7fa1fNp90mdcA1n49Nh+mH52Ze/ljef3WPVuO7l/pMburbGT3XRD1V588fnPz2Hr0U13JdtsxqZTPAefFt07n4+ivciLY7H8k3haT375YV7VflPH5I8C6t+N6toVqdpj7u6zvbL8NgZub+XN285fRgft9n6GZ7QSOmtnOoq5yXlBHbV85J6orzqeUk95TV9XlZPfdXzf+i5nHoLf/P0n/JF9uy6fmoGhO+3kaNWdr//DxkHGpY=

Copy blueprint


Screenshot @ 60 UPS:

Unbenannt.PNG (779.7 KiB) Viewed 5009 times

[Rseding91]

Thanks for the report. I don't think this will ever be fixed. Blueprinting trains on curves just doesn't work due to how trains align themselves to rails at a fundamental level.

I'll assign this to Kovarex but i don't think there's a solution except "don't blueprint trains on curves".

[AntiElitz]

I have to second this report [0.18.10], It's really annoying because its so inconsistent. Not blueprinting on a curve is not really a solution you can manage to do in a naturally grown base.

[schmorp]

I note that the original bug report says "mostly" on curves, and indeed, this happens for me on straight rails [0.18.32], mostly when I have a blueprint with many trains in them, such as when building an LTN depot - out of ten trains, usually 2-4 do not receive their fuel.

[kovarex]

Hello, the bug was quite straightforward.

The storytime:
4 years ago, when the feature to allow construction robots deliver modules into machines as part of a blueprint or upgrade operation, it wasn't really considered that it might have something to do with moving entities.

So there was a condition: whenever the surface, force or position of the entity changes, just cancel the request.

Since the trains tend to move a little here and there when the blueprint for trains is being completed, that caused the request to be randomly removed.

Well, removing the if and making the request follow the train around was simple and it solved the original bug, but now we had a new problem: when the robot is chasing the locomotive to insert the fuel, but it already has some and runs away, the robots just follows it intil it runs out of power and get stuck in an infinite loop trying to get to the locomotive somewhere deep in the wilderness.

Long story short, the special logic that calls off robots chasing damaged vehicles to repair them when they run out of the logistic network had to be extended for this case, but it works and this smal bug will be finally solved.

TL;DR; Solved for the next release

[AntiElitz]

Nice! Thank you

[azesmbog]

With blueprints and train fuel, I have had the following problem for a long time -
when building a train remotely, (this is when I am not directly present,
and I'm building something several thousand kilometers away), then construction drones build both the rails and the train itself, but they never add fuel, although it is on the blueprint. This is a very, very, very bad drone behavior. Some nuance and peculiarity is that drones take rails, train, wagons and fuel not from a supply or storage chest, but from what they hold in their paws , from the destroyed previous train, to be more precise.
They can build rails, a train and cars from this, but they cannot load a train with fuel: (((As they kept fuel with them, they keep it.
As I understand it, they need to put it in the storage chest and take it from there.
But with everything else, they don't need it !!!!
Of course, I resigned myself to such their unworthy behavior, but maybe this can also be fixed ??
If I didn't understand it, then all I can do is take a screenshot. If it's necessary
To clarify - there are only construction drones!
Or should transport drones deliver fuel?