on_selected_entity_changed::entity (optional)

[LuziferSenpai]

Hey,

it would nice to get the entity that is currently selected, if one is selected, as third output out of the event.

Because otherwise we always need to do game.players[event.player_index].selected.

Greetz,

Luzifer

[darkfrei]

+1
It will be very helpful by this mod: https://mods.factorio.com/mod/TorchLight

Right now it needs to check every player's selected_entity on every tick.

[Klonan]

Because otherwise we always need to do game.players[event.player_index].selected.

And whats wrong with doing that?

[Optera]

Because otherwise we always need to do game.players[event.player_index].selected.

And whats wrong with doing that?

Building a player object just to check if there is an entity under cursor.
On cpp side you should already know if there's an entity in which case passing it along would be simple.

[LuziferSenpai]

Because otherwise we always need to do game.players[event.player_index].selected.

And whats wrong with doing that?

What Optera says, to check if a player has something selected is just so much performance cost.

[Rseding91]

The exact reason why you want it added is the exact reason why it doesn't exist. You would pay that performance cost every time the event fired to push the new LuaEntity into the event handler.

Instead, cache the player on your end if its that slow and you want to read it.

[LuziferSenpai]

The exact reason why you want it added is the exact reason why it doesn't exist. You would pay that performance cost every time the event fired to push the new LuaEntity into the event handler.

Instead, cache the player on your end if its that slow and you want to read it.

Then why do you pass last_entity? It would be the same result. I dont understand that, but okay ...

[Rseding91]

The exact reason why you want it added is the exact reason why it doesn't exist. You would pay that performance cost every time the event fired to push the new LuaEntity into the event handler.

Instead, cache the player on your end if its that slow and you want to read it.

Then why do you pass last_entity? It would be the same result. I dont understand that, but okay ...

Because there's no other way to get it.