0.18.14 show_side_menu

[Optera]

Problem:

Code: Select all

/c game.player.game_view_settings.show_side_menu  = false

sometimes results in weird glitches

2020-03-19-10-49-50-0870990.png (425.83 KiB) Viewed 4068 times

Reproduction:
Sometimes I have to toggle show_side_menu on and off a few times

Expected:
show_side_menu = false hides toolbar without distorting research and minimap elements.

[posila]

Confirmed. Works if I turn it off once, but when turn it back on and off again, it breaks. I was able to reproduce it also in 0.18.12, so unrelated to recent GUI changes

[Optera]

It may have been a glitch since show_side_menu was introduced.
I recall that bar being the one thing I couldn't remove when I made UI Hotkeys a year ago.

[Rseding91]

I'll leave this for someone else to look into. As far as I know, everything in the right-container bases its size off the side_menu. So, it not being there kind of just collapses all of that logic and you get what you get.

[Optera]

I'll leave this for someone else to look into. As far as I know, everything in the right-container bases its size off the side_menu. So, it not being there kind of just collapses all of that logic and you get what you get.

That doesn't quite make sense with a workaround I discovered.
If research and map are disabled together with menu and then enabled again they keep their normal size.

[Rseding91]

I'll leave this for someone else to look into. As far as I know, everything in the right-container bases its size off the side_menu. So, it not being there kind of just collapses all of that logic and you get what you get.

That doesn't quite make sense with a workaround I discovered.
If research and map are disabled together with menu and then enabled again they keep their normal size.

Yeah that sounds expected. There's a property called "don't decrease width" which would cause that exact behavior. Once sized larger, the text doesn't shrink. But the size is still based off the side menu or minimap.

Personally it doesn't sound worth doing anything about to me. The entire right-side menu is meant to work as one large collection of things. Ripping out parts breaks that because it was never meant to have parts ripped out. Unfortunately features got tacked on and now we're here with some of them not working right.

[Optera]

Almost sounds like you plan on fixing show_side_menu = false by by removing show_side_menu.

[kovarex]

Thanks for the report, fixed for 1.1