[0.17.79] Please please please let electric poles be rotated

Ideas that are too old (too many things have changed since) and ones which won't be implemented for certain reasons or if there are obviously better suggestions.

Moderator: ickputzdirwech

Rseding91
Factorio Staff
Factorio Staff
Posts: 14630
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: [0.17.79] Please please please let electric poles be rotated

Post by Rseding91 »

I don't see this as ever happening. Electric poles don't have a saved direction and there's zero gameplay benefit to make them have one. It would increase memory usage, save file size, save time, and load time. All for a purely cosmetic reason.
If you want to get ahold of me I'm almost always on Discord.
User avatar
Oktokolo
Filter Inserter
Filter Inserter
Posts: 884
Joined: Wed Jul 12, 2017 5:45 pm
Contact:

Re: [0.17.79] Please please please let electric poles be rotated

Post by Oktokolo »

Rseding91 wrote: Fri Feb 21, 2020 12:53 pm I don't see this as ever happening. Electric poles don't have a saved direction and there's zero gameplay benefit to make them have one. It would increase memory usage, save file size, save time, and load time. All for a purely cosmetic reason.
I am so happy, that decoratives are already in the game as they exactly match that description. ;)
JasonC
Filter Inserter
Filter Inserter
Posts: 449
Joined: Tue Mar 22, 2016 3:05 am
Contact:

Re: [0.17.79] Please please please let electric poles be rotated

Post by JasonC »

Rseding91 wrote: Fri Feb 21, 2020 12:53 pm Electric poles don't have a saved direction
So give them a saved direction. Or give me an NDA and source access and I'll do it then send you an invoice. :lol:
and there's zero gameplay benefit to make them have one. ... a purely cosmetic reason.
Yeah... that's true, but, and I only speak for myself, that kind of cosmetic stuff is an enjoyable part of the game for me. When I look at reddit and these forums I see a lot of players putting a lot of effort into things that are, for the most part, cosmetic, especially in the way factories and belts are arranged, and I think fixing this particular thing (electric pole orientation) has a lot of value in that respect. But I get that it's not of high importance.

Would be nice, though.
Last edited by JasonC on Fri Feb 21, 2020 3:51 pm, edited 1 time in total.
Took a break from 0.12.29 to 0.17.79, and then to ... oh god now it's 1.something. I never know what's happening.
JasonC
Filter Inserter
Filter Inserter
Posts: 449
Joined: Tue Mar 22, 2016 3:05 am
Contact:

Re: [0.17.79] Please please please let electric poles be rotated

Post by JasonC »

Rseding91 wrote: Fri Feb 21, 2020 12:53 pmIt would increase memory usage, save file size, save time, and load time
Could the impact here be reduced to acceptable levels by only saving orientation state for poles whose orientation has been manually set by the user?
Took a break from 0.12.29 to 0.17.79, and then to ... oh god now it's 1.something. I never know what's happening.
Rseding91
Factorio Staff
Factorio Staff
Posts: 14630
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: [0.17.79] Please please please let electric poles be rotated

Post by Rseding91 »

JasonC wrote: Fri Feb 21, 2020 3:50 pm
Rseding91 wrote: Fri Feb 21, 2020 12:53 pmIt would increase memory usage, save file size, save time, and load time
Could the impact here be reduced to acceptable levels by only saving orientation state for poles whose orientation has been manually set by the user?
Serialization doesn't work that way. You can't conditionally not load something without having something to load that says if you should or shouldn't load more.
If you want to get ahold of me I'm almost always on Discord.
User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 5211
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: [0.17.79] Please please please let electric poles be rotated

Post by eradicator »

Rseding91 wrote: Fri Feb 21, 2020 12:53 pm I don't see this as ever happening. Electric poles don't have a saved direction and there's zero gameplay benefit to make them have one. It would increase memory usage, save file size, save time, and load time. All for a purely cosmetic reason.
From looking at this thread from afar... isn't this simply about the prototype wire connection points? If for all directions the red connection point is on the "left" and the green on the "right" the wires should never cross should they?
Author of: Belt Planner, Hand Crank Generator, Screenshot Maker, /sudo and more.
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.
JasonC
Filter Inserter
Filter Inserter
Posts: 449
Joined: Tue Mar 22, 2016 3:05 am
Contact:

Re: [0.17.79] Please please please let electric poles be rotated

Post by JasonC »

Rseding91 wrote: Fri Feb 21, 2020 3:55 pm
JasonC wrote: Fri Feb 21, 2020 3:50 pm
Rseding91 wrote: Fri Feb 21, 2020 12:53 pmIt would increase memory usage, save file size, save time, and load time
Could the impact here be reduced to acceptable levels by only saving orientation state for poles whose orientation has been manually set by the user?
Serialization doesn't work that way. You can't conditionally not load something without having something to load that says if you should or shouldn't load more.
I know; but I can also conceive of logic that treats user-rotated poles almost like separate entities, so you don't have to mix them in with automatic poles - [de]serializing manual ones as a separate collection from non-manual ones. But I also understand that the game might not have the architecture to do something like that, or that the effort to add it outweighs the benefit, or that it could add a whole host of possible new bugs.

Is something like that a possibility, though?
Last edited by JasonC on Fri Feb 21, 2020 4:07 pm, edited 1 time in total.
Took a break from 0.12.29 to 0.17.79, and then to ... oh god now it's 1.something. I never know what's happening.
User avatar
Optera
Smart Inserter
Smart Inserter
Posts: 2920
Joined: Sat Jun 11, 2016 6:41 am
Contact:

Re: [0.17.79] Please please please let electric poles be rotated

Post by Optera »

eradicator wrote: Fri Feb 21, 2020 3:55 pm
Rseding91 wrote: Fri Feb 21, 2020 12:53 pm I don't see this as ever happening. Electric poles don't have a saved direction and there's zero gameplay benefit to make them have one. It would increase memory usage, save file size, save time, and load time. All for a purely cosmetic reason.
From looking at this thread from afar... isn't this simply about the prototype wire connection points? If for all directions the red connection point is on the "left" and the green on the "right" the wires should never cross should they?
By your own definition Rseding, poles should only have one predefined way of connecting wires. e.g. bottom left green, center copper, top right red
The current way of somewhat randomly rotating connections is only cosmetic, requires additional sprites to be loaded and therefore should be removed.
JasonC
Filter Inserter
Filter Inserter
Posts: 449
Joined: Tue Mar 22, 2016 3:05 am
Contact:

Re: [0.17.79] Please please please let electric poles be rotated

Post by JasonC »

eradicator wrote: Fri Feb 21, 2020 3:55 pm
Rseding91 wrote: Fri Feb 21, 2020 12:53 pm I don't see this as ever happening. Electric poles don't have a saved direction and there's zero gameplay benefit to make them have one. It would increase memory usage, save file size, save time, and load time. All for a purely cosmetic reason.
From looking at this thread from afar... isn't this simply about the prototype wire connection points? If for all directions the red connection point is on the "left" and the green on the "right" the wires should never cross should they?
Well, "bottom left" and "top right" (or whatever) for thoroughness; but for something like that I can always imagine edge cases where wires, while not necessarily crossing, obscure eachother because they're all on the same line; especially in setups that mix diagonal and orthogonal wires.
Took a break from 0.12.29 to 0.17.79, and then to ... oh god now it's 1.something. I never know what's happening.
JasonC
Filter Inserter
Filter Inserter
Posts: 449
Joined: Tue Mar 22, 2016 3:05 am
Contact:

Re: [0.17.79] Please please please let electric poles be rotated

Post by JasonC »

PS, Fwiw, regarding performance impacts, I personally don't mind increases in save file size. They're already not that big and storage space is virtually a non-issue these days. Same with memory usage, within reason. Save/load times, though, is something I care about (although right now they're more than acceptable but I also have a brand new machine with a pair of RAID-1 NVMe SSDs, 16 i9s, and a ton of PCIe bandwidth, and I'm pretty sure I/O and file size aren't the bottleneck in save/load, but I don't know about the [un]zipping).
Took a break from 0.12.29 to 0.17.79, and then to ... oh god now it's 1.something. I never know what's happening.
User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 5211
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: [0.17.79] Please please please let electric poles be rotated

Post by eradicator »

eradicator wrote: Fri Feb 21, 2020 3:55 pm From looking at this thread from afar... isn't this simply about the prototype wire connection points? If for all directions the red connection point is on the "left" and the green on the "right" the wires should never cross should they?
So, i did my homework now and noticed that the existance of two different diagonal variants seems to make this impossible. (Disclaimer: I really don't want to take sides in another "OCD" vs "a bit of chaos looks nice" discussion so i'm posting this simply "as is".)
cableplot.png
cableplot.png (14.09 KiB) Viewed 3420 times
Author of: Belt Planner, Hand Crank Generator, Screenshot Maker, /sudo and more.
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.
User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 5211
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: [0.17.79] Please please please let electric poles be rotated

Post by eradicator »

After fixing some errors it looks like swapping the attachment rules for only one of the diagonal variants seems to work.
cableplot-swap.png
cableplot-swap.png (13.07 KiB) Viewed 3419 times
Author of: Belt Planner, Hand Crank Generator, Screenshot Maker, /sudo and more.
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.
User avatar
valneq
Smart Inserter
Smart Inserter
Posts: 1262
Joined: Fri Jul 12, 2019 7:43 am
Contact:

Re: [0.17.79] Please please please let electric poles be rotated

Post by valneq »

Wait … these are only for two poles placed horizontally. How about placing poles vertically? This problem should not have full rotational symmetry.
User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 5211
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: [0.17.79] Please please please let electric poles be rotated

Post by eradicator »

valneq wrote: Fri Feb 21, 2020 5:12 pm Wait … these are only for two poles placed horizontally. How about placing poles vertically? This problem should not have full rotational symmetry.
Yep. Exactly. *sigh*. That was my first thought, then i did some half-assed testing and it seemed it worked. Now i did some more testing and back to: "For any pair of poles with non-identical rotation there exists two positions A,B for which the wires will cross each other." Which is basically the point of overlapping for identically rotates poles. And i also noticed that what i proposed as "fix" is exactly how the game already does it. These moments when you notice you were right saying nothing all along and shouldn't have stopped doing that...

Oh, btw, substations actually violate the scheme for three of four rotations:
swapstationcolors.png
swapstationcolors.png (1.28 MiB) Viewed 3408 times
Author of: Belt Planner, Hand Crank Generator, Screenshot Maker, /sudo and more.
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.
User avatar
Oktokolo
Filter Inserter
Filter Inserter
Posts: 884
Joined: Wed Jul 12, 2017 5:45 pm
Contact:

Re: [0.17.79] Please please please let electric poles be rotated

Post by Oktokolo »

eradicator wrote: Fri Feb 21, 2020 5:42 pm Oh, btw, substations actually violate the scheme for three of four rotations:
That probably is a (minor) bug.
Post Reply

Return to “Outdated/Not implemented”