[Dominik][0.17.65] Underground pipes of different length issue+crash [mods]

[boskid]

Using mods:
- "advanced underground piping"

Issue: when using underground pipes of different lengths, it is possible to create long reach underground pipe that shows as connected when in fact it is blocked.

1. Setup (with ruler to show where regular undergrounds will not connect):

   

   ovup-1.png (103.1 KiB) Viewed 4323 times

2. Place pipe-to-ground near water. It will not connect to right underground pipe because of distance

   

   ovup-2.png (56.49 KiB) Viewed 4323 times

3. Place "Tier 3 1 to 1 forward pipe" near crude oil. It will not connect to right underground pipe because of regular pipe to ground 2 tiles to right

   

   ovup-3.png (57.22 KiB) Viewed 4323 times

4. Remove regular pipe-to-ground near water. After this, outer two long range pipe to grounds show as connected even if no fluid system merge is performed

   

   ovup-4.png (57.9 KiB) Viewed 4323 times

5. Outer undergrounds show as connected

----

There is also crash possibility:

Code: Select all

 196.709 Error FluidSystem.cpp:171: connection.isConnected() was not true

When outer undergrounds are indeed marked as blocked, by building regular pipe to ground near water, outer undergrounds will still show as paired+blocked but removing one assembler will crash:

overlap-undergrounds-crash.gif (468.51 KiB) Viewed 4323 times

----
Also there are other issues with undergrounds of different length: build long underground section using long reach underground pipes, then inside build next underground section with shorter reach undergrounds so that they will not reach outer pipe-to-grounds so they do not disconnect.

ovup-5.png (89.52 KiB) Viewed 4323 times

[Staplergun]

This was able to be done under the old system, too. Here's an example of tri layer. https://www.reddit.com/r/factorio/comme ... _give_you/

[boskid]

This was able to be done under the old system, too. Here's an example of tri layer. https://www.reddit.com/r/factorio/comme ... _give_you/

Oh, 3 underground pipes overlapping, so cute.

can-i-do-more-underground-pipes.gif (2.63 MiB) Viewed 4233 times

log

Code: Select all

c:\cygwin64\tmp\factorio-build-3kglwi\src\entity\pipe.cpp (278): Pipe::updateFluidBoxPointer
c:\cygwin64\tmp\factorio-build-3kglwi\src\fluid\fluidbox.cpp (560): FluidBox::FluidBox
c:\cygwin64\tmp\factorio-build-3kglwi\src\fluid\fluidmanager.cpp (96): FluidManager::changeFluidSystem
c:\cygwin64\tmp\factorio-build-3kglwi\src\fluid\fluidmanager.cpp (135): FluidManager::assignFluidSystemRecursive
c:\cygwin64\tmp\factorio-build-3kglwi\src\fluid\fluidmanager.cpp (297): FluidManager::moveOut
c:\cygwin64\tmp\factorio-build-3kglwi\src\entity\pipe.cpp (85): PipeToGround::onDestroy
c:\cygwin64\tmp\factorio-build-3kglwi\src\entity\entity.cpp (302): Entity::forceDestroy
c:\cygwin64\tmp\factorio-build-3kglwi\src\manualstorage.cpp (215): ManualStorage::handleMinedEntity
c:\cygwin64\tmp\factorio-build-3kglwi\src\manualminer.cpp (124): ManualMiner::performMining
c:\cygwin64\tmp\factorio-build-3kglwi\src\controller\editorcontroller.cpp (258): EditorController::update
c:\cygwin64\tmp\factorio-build-3kglwi\src\map\map.cpp (1513): Map::updateEntities
c:\cygwin64\tmp\factorio-build-3kglwi\src\game.cpp (201): Game::update
c:\cygwin64\tmp\factorio-build-3kglwi\src\scenario\scenario.cpp (1215): Scenario::update
c:\cygwin64\tmp\factorio-build-3kglwi\src\mainloop.cpp (1167): MainLoop::gameUpdateStep
c:\cygwin64\tmp\factorio-build-3kglwi\src\mainloop.cpp (1036): MainLoop::gameUpdateLoop
c:\cygwin64\tmp\factorio-build-3kglwi\src\util\workerthread.cpp (42): WorkerThread::loop

Code: Select all

85.790 Error Pipe.cpp:278: this->fluidBox == oldAddress was not true

[Staplergun]

Oh man. Total power move. Well played.

[Oktokolo]

Another oportunity to fix a bug into a feature: Let us have pipe weaving like we already have for belts.

[BlueTemplar]

One problem is that, unlike for belts, the pipes that are underground, do not exist - IMHO it's better to keep both behaviors as different as possible ?

[Staplergun]

Yeah, pipes don't work like that....it's only working because of odd checks by the long pipes based on which side you start with.

[Dominik]

Ahhh, I think that I was aware of this issue long time ago when fixing something for these modded pipes. Left it alone until it reveals itself.
Problem is that when building a pipe, it searches for a connection as far as its range is. So when you build the normal pipe, the search does not reach the long one and does not tell it that it should disconnect. It looks like that all underground connections will have to seach as far as is the longest connection possible in the game. Which is not nice.