[Rseding91] [0.17.65] LuaForce double limits

[boskid]

character_running_speed_modifier

1. Code: Select all

   /c game.forces["player"].character_running_speed_modifier=1e308

2. Move left
3. Crash
   log

   Code: Select all

   c:\cygwin64\tmp\factorio-build-skmdfo\src\surface\chunk.cpp (699): Chunk::Chunk
   c:\cygwin64\tmp\factorio-build-skmdfo\src\entity\updatableentity.cpp (59): UpdatableEntity::updateLinkInternal
   c:\cygwin64\tmp\factorio-build-skmdfo\src\entity\character.cpp (2418): Character::changePosition
   c:\cygwin64\tmp\factorio-build-skmdfo\src\entity\character.cpp (702): Character::update
   c:\cygwin64\tmp\factorio-build-skmdfo\src\surface\chunk.cpp (577): Chunk::updateActiveEntities
   c:\cygwin64\tmp\factorio-build-skmdfo\src\surface\chunk.cpp (634): Chunk::updateEntities
   c:\cygwin64\tmp\factorio-build-skmdfo\src\surface\surface.cpp (1458): Surface::update
   c:\cygwin64\tmp\factorio-build-skmdfo\src\map\map.cpp (1501): Map::updateEntities
   c:\cygwin64\tmp\factorio-build-skmdfo\src\game.cpp (201): Game::update
   c:\cygwin64\tmp\factorio-build-skmdfo\src\scenario\scenario.cpp (1215): Scenario::update
   c:\cygwin64\tmp\factorio-build-skmdfo\src\mainloop.cpp (1167): MainLoop::gameUpdateStep
   c:\cygwin64\tmp\factorio-build-skmdfo\src\mainloop.cpp (1036): MainLoop::gameUpdateLoop
   c:\cygwin64\tmp\factorio-build-skmdfo\src\util\workerthread.cpp (42): WorkerThread::loop

   Code: Select all

     20.924 Error Chunk.cpp:699: Trying to make chunk at unreasonable position [-262144, 0]

----
character_health_bonus

1. Code: Select all

   /c game.forces["player"].character_health_bonus=1e308

2. Get hit by biter
3. Total factorio freeze, no crash, no log update, cannot close with "X"

----
character_logistic_slot_count

1. Code: Select all

   /c game.forces["player"].character_logistic_slot_count=1e10

2. Crash
   log

   Code: Select all

   c:\cygwin64\tmp\factorio-build-skmdfo\src\util\luaexceptionhelper.cpp (66): LuaExceptionHelper::LogAndAbort
   c:\cygwin64\tmp\factorio-build-skmdfo\src\script\luabinder.hpp (340): `LuaBinder<LuaLampControlBehavior>::callWrapper'::`1'::catch$1
   f:\dd\vctools\crt\vcruntime\src\eh\amd64\handlers.asm (50): _CallSettingFrame
   f:\dd\vctools\crt\vcruntime\src\eh\frame.cpp (1528): __FrameHandler3::CxxCallCatchBlock
   ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFFD33E05E6)
   00007FFFD33E05E6 (ntdll): (filename not available): RtlCaptureContext
   c:\cygwin64\tmp\factorio-build-skmdfo\src\script\luabinder.hpp (326): LuaBinder<LuaRecipePrototype>::callWrapper
   c:\cygwin64\tmp\factorio-build-skmdfo\libraries\lua\ldo.c (350): luaD_precall
   c:\cygwin64\tmp\factorio-build-skmdfo\libraries\lua\ldo.c (423): luaD_call
   c:\cygwin64\tmp\factorio-build-skmdfo\libraries\lua\lvm.c (104): callTM
   c:\cygwin64\tmp\factorio-build-skmdfo\libraries\lua\lvm.c (168): luaV_settable
   c:\cygwin64\tmp\factorio-build-skmdfo\libraries\lua\lvm.c (601): luaV_execute
   c:\cygwin64\tmp\factorio-build-skmdfo\libraries\lua\lapi.c (1027): f_call
   c:\cygwin64\tmp\factorio-build-skmdfo\libraries\lua\ldo.c (137): luaD_rawrunprotected
   c:\cygwin64\tmp\factorio-build-skmdfo\libraries\lua\ldo.c (623): luaD_pcall
   c:\cygwin64\tmp\factorio-build-skmdfo\src\script\luagamescript.cpp (1437): LuaGameScript::runLuaCommand
   c:\cygwin64\tmp\factorio-build-skmdfo\src\script\luacontext.cpp (246): LuaContext::runLuaCommand
   c:\cygwin64\tmp\factorio-build-skmdfo\src\commandprocessor.cpp (1447): CommandProcessor::doExecuteCommand
   c:\cygwin64\tmp\factorio-build-skmdfo\src\commandprocessor.cpp (298): CommandProcessor::executeCommand
   c:\cygwin64\tmp\factorio-build-skmdfo\src\commandprocessor.cpp (245): CommandProcessor::process
   c:\cygwin64\tmp\factorio-build-skmdfo\src\gameactionhandler.cpp (3605): GameActionHandler::writeToConsole
   c:\cygwin64\tmp\factorio-build-skmdfo\src\gameactionhandler.cpp (331): GameActionHandler::actionPerformed
   c:\cygwin64\tmp\factorio-build-skmdfo\src\input\inputhandler.cpp (61): InputHandler::flushActions
   c:\cygwin64\tmp\factorio-build-skmdfo\src\gameactionhandler.cpp (371): GameActionHandler::update
   c:\cygwin64\tmp\factorio-build-skmdfo\src\mainloop.cpp (1161): MainLoop::gameUpdateStep
   c:\cygwin64\tmp\factorio-build-skmdfo\src\mainloop.cpp (1036): MainLoop::gameUpdateLoop
   c:\cygwin64\tmp\factorio-build-skmdfo\src\util\workerthread.cpp (42): WorkerThread::loop

   Code: Select all

   862.692 Error LuaExceptionHelper.cpp:66: Unexpected error: bad allocation

----
character_trash_slot_count
If set to 1e10, moderate UPS/FPS drop when looking into inventory
----
manual_crafting_speed_modifier

1. Code: Select all

   /c game.forces["player"].manual_crafting_speed_modifier = -2

2. 

   74542-negative-crafting-speed.gif (30.25 KiB) Viewed 1868 times

----
character_inventory_slots_bonus (uint, not double)

1. Code: Select all

   /c game.forces["player"].character_inventory_slots_bonus = 1e10

2. Player with total of 0 inventory slots

character_inventory_slots_bonus of 65457 (2^16 - 79) gives 1 total slot of player inventory
----
mining_drill_productivity_bonus

• Code: Select all

  /c game.forces["player"].mining_drill_productivity_bonus = 1e100

• Place miner and power it
• Crash
  log

  Code: Select all

  c:\cygwin64\tmp\factorio-build-skmdfo\src\util\crashhandler.cpp (564): CrashHandler::NewHandler
  minkernel\crts\ucrt\src\appcrt\heap\new_handler.cpp (79): _callnewh
  f:\dd\vctools\crt\vcstartup\src\heap\new_scalar.cpp (40): operator new
  c:\program files (x86)\microsoft visual studio\2017\buildtools\vc\tools\msvc\14.15.26726\include\xmemory0 (184): std::_Allocate<16,std::_Default_allocate_traits,0>
  c:\program files (x86)\microsoft visual studio\2017\buildtools\vc\tools\msvc\14.15.26726\include\deque (1833): std::deque<std::vector<InputActionSegment,std::allocator<InputActionSegment> >,std::allocator<std::vector<InputActionSegment,std::allocator<InputActionSegment> > > >::_Growmap
  c:\program files (x86)\microsoft visual studio\2017\buildtools\vc\tools\msvc\14.15.26726\include\deque (1136): std::deque<ItemStack,std::allocator<ItemStack> >::emplace_back<>
  c:\cygwin64\tmp\factorio-build-skmdfo\src\mining\miningcollector.cpp (52): ResourceMiningCollector::transfer
  c:\cygwin64\tmp\factorio-build-skmdfo\src\material\productprototype.cpp (104): ItemProductPrototype::collect
  c:\cygwin64\tmp\factorio-build-skmdfo\src\entity\miningdrill.cpp (620): MiningDrill::performMining
  c:\cygwin64\tmp\factorio-build-skmdfo\src\entity\miningdrill.cpp (683): MiningDrill::update
  c:\cygwin64\tmp\factorio-build-skmdfo\src\surface\chunk.cpp (577): Chunk::updateActiveEntities
  c:\cygwin64\tmp\factorio-build-skmdfo\src\surface\chunk.cpp (634): Chunk::updateEntities
  c:\cygwin64\tmp\factorio-build-skmdfo\src\surface\surface.cpp (1458): Surface::update
  c:\cygwin64\tmp\factorio-build-skmdfo\src\map\map.cpp (1501): Map::updateEntities
  c:\cygwin64\tmp\factorio-build-skmdfo\src\game.cpp (201): Game::update
  c:\cygwin64\tmp\factorio-build-skmdfo\src\scenario\scenario.cpp (1215): Scenario::update
  c:\cygwin64\tmp\factorio-build-skmdfo\src\mainloop.cpp (1167): MainLoop::gameUpdateStep
  c:\cygwin64\tmp\factorio-build-skmdfo\src\mainloop.cpp (1036): MainLoop::gameUpdateLoop
  c:\cygwin64\tmp\factorio-build-skmdfo\src\util\workerthread.cpp (42): WorkerThread::loop

---- Not LuaForce, but also limit cases:
player.zoom:

1. Code: Select all

   /c game.player.zoom = 1e-3

2. Huge FPS/UPS drop

[Rseding91]

I can "fix" some of these. Others aren't bugs or are "play stupid games, win stupid prizes"

[Rseding91]

I've fixed the health crash and the rest are fine to leave as is. The other 2 crashes are running out of memory and it failing to allocate what i tneeds to do what you told it to do - which is fine. Just don't tell it you want a 10,000,000,000 logistic slots if you don't have the RAM for them.

[boskid]

I can "fix" some of these. Others aren't bugs or are "play stupid games, win stupid prizes"

Garbage in garbage out. Lets remove all limits. What if malformed mod starts writing bad values? Everyone on multiplayer should crash because of bad_alloc?

[someone1337]

the solution would be to not use buggy mods

[Rseding91]

I can "fix" some of these. Others aren't bugs or are "play stupid games, win stupid prizes"

Garbage in garbage out. Lets remove all limits. What if malformed mod starts writing bad values? Everyone on multiplayer should crash because of bad_alloc?

Either that, or they all get booted back to the main menu due to mod errors.