[0.17.63] Factorio no longer recognizing monitor changes

[Jon8RFC]

Run Factorio.
Enable Settings>Graphics>"minimize on focus loss".
Keep Factorio running.
Plug in or unplug a secondary monitor.
Change the foreground app from Factorio to something else.
Cannot bring Factorio back to foreground.

Happens with force opengl set to either false or true. I don't see in the logs when a monitor is plugged in or removed

Code: Select all

Device reset external.

and that used to show, I guess in 0.16 and prior, so maybe Factorio doesn't know there's been a state change. Whether "minimize on focus loss" is enabled or not, that line is not shown in the logs.

[posila]

One day, I'll work on a console game and won't have to deal with these issues ... one day
Also, I never thought I'd say this, but I start to miss Allegro. I kind of assumed SDL would have all these corner cases figured out by now.

Semi-fixed for 0.17.64

For the record: device resets in 0.16 are undesirable event when DirectX device needs to be reinitialized. Because it happed so often in DirectX 9, the game had to keep backup copy of all textures in RAM so it can recover from the reset fast. OpenGL nor DirectX 11 doesn't suffer from these kind of resets. (Although DX11 device can still reset, but it should happen only in very rarely, ... in reallity it is not as rare as documentation would let one believe, but still not something worth keeping textures in RAM)

[Jon8RFC]

Wow, that was a quick investigation! Thanks for the background information, too. It's interesting even if I don't understand it.

Ryan Gordon is a pretty communicative guy, so I bet if y'all shot some specific cases to him (like with AMD for Ryzen), he or someone else at SDL would take care of them.