[0.17.54] Sync mods with save: disabled mods show as "keep enabled"

[someone1337]

When clicking Sync mods with save, it lists all my mods - even disabled ones - as active and allows me to "keep enabled" mods that are disabled (and in fact were not even ported to 0.17 (yet))

some-npp was an experiment in 0.16 which i still hjave not given up yet on, but that mod is definitely not a 0.17 mod.

Expected behaviour:
All but "some-disableenemygeneration" should not have "keep enabled" -as they are not enabled atm- besides them, and ideally they would not even get listed OR the "keep enabled" label should be changed to "enable newly" or something like that

but currently its misleading on what is currently enabled.

[Rseding91]

Can you please upload your mods folder and the save file you're using to reproduce this? When I test things, they all work fine.

[someone1337]

Here you go. (Still an issue with 0.17.55)

[Rseding91]

Thanks for the mods and save however when I test out that mods folder and that save everything matches perfectly how it should: the mods that are disabled are still set to be disabled and the ones that are enabled are set to stay enabled.

[MashTrapper]

I have this problem, or one very similar, too. It started with the update to 17.54 from 17.49 on GOG Galaxy.

The Sync button shows mods are out of sync when they're properly in sync.

Load Requester with Syncronised Mods.

Mods_Synced.png (1.23 MiB) Viewed 4246 times

Sync requester shows all mods, including inactive mods, as active.

Sync Requester incorrectly shows inactive mods as active.

Mods_Synced_List.png (186.61 KiB) Viewed 4246 times

[Rseding91]

I have this problem, or one very similar, too. It started with the update to 17.54 from 17.49 on GOG Galaxy.

The Sync button shows mods are out of sync when they're properly in sync.

Sync requester shows all mods, including inactive mods, as active.

That's not what that means. If they're not checked as "Keep enabled" it means they aren't enabled or are enabled and will be disabled. It's basically saying "these aren't in the save and i'm going to leave them as they are (disabled)".

[MashTrapper]

I have this problem, or one very similar, too. It started with the update to 17.54 from 17.49 on GOG Galaxy.

The Sync button shows mods are out of sync when they're properly in sync.

Sync requester shows all mods, including inactive mods, as active.

That's not what that means. If they're not checked as "Keep enabled" it means they aren't enabled or are enabled and will be disabled. It's basically saying "these aren't in the save and i'm going to leave them as they are (disabled)".

The Sync button in the Load requester never greys out, indicating the save is never in sync with active mods when it actually is in proper sync. I was expecting it to be greyed out when everything is in sync.


I was also expecting the "Not in save'" list to contain only active mods rather than both active and inactive mods. It would list only active mods that were not in save, but never show inactive mods prior to .17.54. I'd just like to be sure what it's doing here is now expected.

[Rseding91]

The fact it's not grayed out means your startup settings don't match what the save has *OR* your enabled mods doesn't match what the save had (either you have newer/old versions of enabled mods or just different mods).

[MashTrapper]

The fact it's not grayed out means your startup settings don't match what the save has *OR* your enabled mods doesn't match what the save had (either you have newer/old versions of enabled mods or just different mods).

I've just completely uninstalled Factorio, deleted the AppData\Roaming\Factorio folder and reinstalled a clean version 0.17.49 using GOG Galaxy.

I then downloaded five mods: Orphan Finder, QoL-TempStations, VehicleSnap, tree_collision and rso-mod.

I then created three new games. One with no mods, one with all but rso-mod, and a final save with all mods enabled.

Everything works as expected using version 0.17.49. No problems with syncing mods. The sync button properly greys out and only active mods are listed to be kept inactive.



I then updated to 0.17.54, again using GOG Galaxy. This is the ONLY change I have made between the two tests.

Testing using the very same saves that I had created with 0.17.49, the ONLY change being the upgrade to 0.17.54:

The sync button is not greying out for any of my saves, indicating they're all out of sync, and syncing lists all mods, whether active or inactive.

The settings and mods are actually verified to be synced between all saves, yet the GUI does not reflect this.


Finally, I created three new saves using 0.17.54 using the above procedure and I again had the same sync problems.



TL;DR

If I'm telling it to sync, and the sync button is not greyed out after performing the sync, wouldn't that mean that something is not being properly sync'ed that should be?


Something is clearly wrong with save sync. Help!

[Rseding91]

My guess: it's seeing the base game version change as a mod version changing.

[Rseding91]

Ok, I spent some more time looking into this and managed to reproduce it. It should be fixed for the next version of 0.17.

[otakushowboat]

I am having a similar, yet far worse issue with 0.17.57. Regardless of save, even with all mods disabled, attempting to sync a save's mods wants to enable ALL mods. Mods that are not currently enabled are listed as enabled and marked as "keep enabled," and mods not associated with the save whatsoever that are listed as disabled are marked to enable. This is happening on every modded save file I have.

20190715144127_1.jpg (195.24 KiB) Viewed 4150 times

20190715144130_1.jpg (168.51 KiB) Viewed 4150 times

[ruspartisan]

I have the same problem in 0.17.57, while 0.17.56 seems to work fine. But it happens only with SOME saves, with others mod sync works correctly. Here is an example of save that tries to load all downloaded mods.

[Rseding91]

It's fixed in 0.17.58.