Auto-barrel doesn't take into account icons with size > 32

[bobingabout]

Firstly, the auto-barrel (data-updates.lua creates a filled barrel item, fill and empty recipes, and assigns icons to them all) icon generation for the fill and empty recipes doesn't take into account icons with a size other than 32.
https://www.dropbox.com/s/qss8qzvvwef7h ... 4.png?dl=0
in this example screenshot, pure water is icon_size 64.

Also, if a fluid doesn't have an icon= tag (EG, it has an icons= tag), the function refuses to run on it at all.

[posila]

Thanks for fixing it for 0.17.43

[eradicator]

Btw, barreling also doesn't account for fluids with localised_name like it could:

Code: Select all

localised_name = {"recipe-name.fill-barrel", fluid.localised_name or  {"fluid-name." .. fluid.name}},

[bobingabout]

Btw, barreling also doesn't account for fluids with localised_name like it could:

Code: Select all

localised_name = {"recipe-name.fill-barrel", fluid.localised_name or  {"fluid-name." .. fluid.name}},

because if no localised_name is specified, that will return nil and use the or condition to use the default.
simple fix.

is it localised or localized? there's a lot of American in the code.

[bobingabout]

Btw, barreling also doesn't account for fluids with localised_name like it could:

Code: Select all

localised_name = {"recipe-name.fill-barrel", fluid.localised_name or  {"fluid-name." .. fluid.name}},

you should probably make a new bug report, as this one is in the resolved bin, and further conversation will likely be ignored.

[eradicator]

Done. viewtopic.php?f=7&t=71193