[Oxyd] [0.17.34] Server crash after user deletes blueprint

[Cooldude2606]

I run the server where this happended; I will include what the user posted onto reddit.

TL;DR
A user reported a server crash to us and explained how he may have been the cause (since he crashed two of our servers doing the same thing) we found quickly that it was because he tried to delete a blueprint. We restarted our server and the logs can be found below. Note that although both seam to have been caused by blueprints each server gave a different stacktrace so may be multiple bugs with removing blueprints.

Users Reddit Post

> Source
I hopped on a multiplayer server i used to frequent to steal their blueprint books. I was messing around for a while then decided one of the unloaded blueprint books , that I had in my personal "saved books" thing that stays between servers, was useless to me and decided to delete it. The server I was on immediately stopped responding and I was kicked from the game after the loading bar hit the end. I waited for a while and the server disappeared from the server list. Confused I hopped onto their second server to continue my blueprint book shenanigans. I saw the blueprint book i didn't want was still in my inventory so, without loading it fully, i tried to delete it. The server began to not respond and eventually did the same thing as the 1st server.

For those of you who got through the grammatically incorrect rambling or for those of you who didnt read it here's the short story of what I think happened:

I attempted to delete an unloaded blueprint book from my personal stash on a server and the server crashed. I did this twice but it could be coincidence.

[Piggu]

(I'm the user he's talking about)
I'm pretty sure the blueprint book I tried to delete both times was The Complete Belt Series: Yellow, Part 1 but I could be remembering wrong

[Cooldude2606]

After finding the other thread i read: "Your steps say something about "The Complete Belt Series: Yellow, Part 1" blueprint book yet no save is provided"
So here is a link to one of the saves: Map save for factorio-previous-server-one.log

(this save were taken after the time of the crash; file is also 45MB)

[TruePikachu]

Both backtraces (I actually have them both visible in a gvimdiff right now) were doing operations related to the blueprint transfer queue, and failed preconditions that a blueprintRecord was true:

Code: Select all

<1> Error BlueprintLibrary.cpp:1052: this->getShelf(player)->getBlueprintRecord(front.id) was not true
<2> Error BlueprintLibrary.cpp:747: blueprintRecord was not true

[Oxyd]

Thanks, should be fixed in 0.17.40.