[0.17.25] game crashes while mod creator tests new fluid turret entity

[kintharo]

i am the mod creator of factorio plus plus and working on a new Version (not live yet)
project: creating an acidspitter Turret (fluid turret Entity)

for testing, i created a Scenario with that turret wich is Ready and armed. Right of it are Aliens.
Walking Right, the Aliens charge, Tower starts to shoot.
Expectation: either Aliens or Player should die after a while.
happens indeed: game crash, an error message occurs which begs me to make this bug report, don´t know when exactly happens, but before Player dies.


the link below gives the crashlog, the non-live Version of actual mod, the Scenario and the crash message
https://we.tl/t-1JxE8qBE3V

[Bilka]

Code: Select all

c:\cygwin64\tmp\factorio-build-w4785s\src\surface\chunk.cpp (682): Chunk::Chunk
c:\cygwin64\tmp\factorio-build-w4785s\src\entity\updatableentity.cpp (59): UpdatableEntity::updateLinkInternal
c:\cygwin64\tmp\factorio-build-w4785s\src\entity\entity.cpp (609): Entity::changePosition
c:\cygwin64\tmp\factorio-build-w4785s\src\entity\unit.cpp (162): Unit::changePosition
c:\cygwin64\tmp\factorio-build-w4785s\src\entity\unit.cpp (146): Unit::moveSmooth
c:\cygwin64\tmp\factorio-build-w4785s\src\ai\gotobehavior.cpp (722): GotoBehavior::execute
c:\cygwin64\tmp\factorio-build-w4785s\src\ai\pursuebehavior.cpp (68): PursueBehavior::execute
c:\cygwin64\tmp\factorio-build-w4785s\src\ai\commandable.cpp (179): Commandable::runBehavior
c:\cygwin64\tmp\factorio-build-w4785s\src\entity\unit.cpp (304): Unit::update
c:\cygwin64\tmp\factorio-build-w4785s\src\surface\chunk.cpp (567): Chunk::updateActiveEntities
c:\cygwin64\tmp\factorio-build-w4785s\src\surface\chunk.cpp (616): Chunk::updateEntities
c:\cygwin64\tmp\factorio-build-w4785s\src\surface\surface.cpp (1366): Surface::update
c:\cygwin64\tmp\factorio-build-w4785s\src\map\map.cpp (1461): Map::updateEntities
c:\cygwin64\tmp\factorio-build-w4785s\src\game.cpp (195): Game::update
c:\cygwin64\tmp\factorio-build-w4785s\src\scenario\scenario.cpp (1166): Scenario::update
c:\cygwin64\tmp\factorio-build-w4785s\src\mainloop.cpp (1115): MainLoop::gameUpdateStep
c:\cygwin64\tmp\factorio-build-w4785s\src\mainloop.cpp (981): MainLoop::gameUpdateLoop
c:\cygwin64\tmp\factorio-build-w4785s\src\util\workerthread.cpp (42): WorkerThread::loop
c:\program files (x86)\microsoft visual studio\2017\buildtools\vc\tools\msvc\14.15.26726\include\thr\xthread (230): std::_LaunchPad<std::unique_ptr<std::tuple<void (__cdecl TransferSource::*)(void),TransferSource *>,std::default_delete<std::tuple<void (__cdecl TransferSource::*)(void),TransferSource *> > > >::_Go
c:\program files (x86)\microsoft visual studio\2017\buildtools\vc\tools\msvc\14.15.26726\include\thr\xthread (209): std::_Pad::_Call_func
minkernel\crts\ucrt\src\appcrt\startup\thread.cpp (115): thread_start<unsigned int (__cdecl*)(void * __ptr64)>
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FF8A56781F4)
00007FF8A56781F4 (KERNEL32): (filename not available): BaseThreadInitThunk
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FF8A5EBA251)
00007FF8A5EBA251 (ntdll): (filename not available): RtlUserThreadStart
Stack trace logging done
  34.022 Error Chunk.cpp:682: Trying to make chunk at unreasonable position [-262143, -262144]

[kintharo]

i forgot to mention, to make the scenario working, set in the mod menu the maximum of upgrade Tiers 5 -> 7 or some entities in that Scenario won´t appear which are needed to make the fluid turret working

[Dominik]

In the log I see that some entity is moving to a position that is out of maximum possible map coordinate, probably the alien. Can you please check that their control script does not contain some bug that would do that?
In the log Commandable::runBehavior -> PursueBehavior::execute-> GotoBehavior::execute -> ... move to position [-262143, -262144]

[Bilka]

The problem is that your "acidspitter-turret-sticker0" has a duration_in_ticks of 0, and we divide by duration_in_ticks in our code.
In the next version, duration_in_ticks will have to be > 0 (having no duration does not make sense anyways). Thanks for the report.